913080 - Make GCGraphBuilder's hash table initialization infallible

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

If we can't even initialize the hash table, we're probably in a really bad state, so we should just crash.  I want to do this because it will avoid some weird failure states that are annoying to deal with.  I couldn't find anything on bugzilla containing the string "Failed to initialize GCGraphBuilder", which is what we assert when this happens, so it seems like even the really OOMy tests manage to get past this part of a CC.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Make GCGraphBuilder's hash table initialization infallible. r=smaug

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=fdc08dad20b1

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Comment on attachment 800396 [details] [diff] [review]
Make GCGraphBuilder's hash table initialization infallible. r=smaug

Try run looks good.  No rush on this review.

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f98b323128d9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f98b323128d9