Closed Bug 913080 Opened 6 years ago Closed 6 years ago

Make GCGraphBuilder's hash table initialization infallible

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If we can't even initialize the hash table, we're probably in a really bad state, so we should just crash.  I want to do this because it will avoid some weird failure states that are annoying to deal with.  I couldn't find anything on bugzilla containing the string "Failed to initialize GCGraphBuilder", which is what we assert when this happens, so it seems like even the really OOMy tests manage to get past this part of a CC.
Blocks: 913130
Comment on attachment 800396 [details] [diff] [review]
Make GCGraphBuilder's hash table initialization infallible. r=smaug

Try run looks good.  No rush on this review.
Attachment #800396 - Flags: review?(bugs)
Attachment #800396 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/f98b323128d9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.