913124 - js/src/jsreflect.cpp:1483:7: warning: 'ASTSerializer' has a field 'ASTSerializer::builder' whose type uses the anonymous namespace [enabled by default]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New GCC 4.8 build warning:
{
js/src/jsreflect.cpp:1483:7: warning: 'ASTSerializer' has a field 'ASTSerializer::builder' whose type uses the anonymous namespace [enabled by default]
}

This was caused by bug 910829's patch, which put NodeBuilder into an anonymous namespace.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0104d0c88a1#l13.1

Comment 1

[Daniel Holbert [:dholbert]]

(Simplest solution would probably be to put ASTSerializer itself into the anonymous namespace, if that works.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1: put ASTSerializer into anonymous namespace, too

This works locally.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55cdc3eef815

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/55cdc3eef815