91320 - Remove unused files from htmlparser module

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[harishd]

Comment 1

[harishd]

** This is a tracking bug **

Comment 2

[harishd]

Remove ValidDTD, prstrm, DTDDebug

Comment 3

[harishd]

Attachment: patch v1.1 [ created public directory and removed a few unwanted files ]

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

1. What is this?:

   +EXPORTS		:= $(addprefix $(srcdir)/, $(EXPORTS))

2. Add newlines to the end of these files at least: MANIFEST, makefile.win and
all the interfaces.
  
3. Remove from nsIContentSink:
   + * This file declares the concrete IContentSink interface.

4. [Optional] Replace the GetIID() implementations with the macro in the 
   interfaces, for example:
   static const nsIID& GetIID() { static nsIID iid = NS_IDTD_IID; return iid; }

5. Is Verify() implemented anywhere after these changes? Maybe the function 
   could be removed althogether?

6. Newlines and tabs... Are you sure newlines are correct in all files? Also
   the below lines have tabs that should be changed to spaces (I suspect
   you have conffed VC++ to convert tabs to spaces in C++ files but not
   in other files, which caused this so check other files as well):
   +MODULE_NAME	   = nsParserModule

7. Make sure that we export as little as possible (like why do we export
   nsParser.h).

8. Should all exportable files be moved to public?

9. What is the deal with nsParser.cpp, it looks like that belongs into some
   other bug?

10. The diff shows you are removing no files, what gives? Did you forget to
    cvs rm the files before you did diff?

Comment 5

[harishd]

Attachment: patch v1.2

Comment 6

[harishd]

Attachment: patch v1.3

Comment 7

[harishd]

Moving to more realistic target - m0.9.4!

Comment 8

[harishd]

Attachment: patch v1.4 [ cvs diff -uN ]

Comment 9

[vidur (gone)]

sr=vidur

Comment 10

[harishd]

cvs removed nsDTDDebug, nsXMLTokenizer, nsTokenHandler, nsValidDTD..

Comment 11

[bsharma]

Verified on 2001-08-08-Trunk build on WinNT.

Marking verified as per above developer comments.