913219 - signaling_unittests needs a more flexible SDP representation

Status: REOPENED

(Core :: WebRTC: Signaling, defect, P5)

Description

[Adam Roach [:abr]]

Right now, a lot of the tests in signaling unittests rely on some rather brittle constructs, such as assuming the order in which SDP sections and attributes appear, and the payload types that will be used in the SDP.

This is very brittle, and results in unnecessary pain whenever the SDP changes in ways the unit tests did not anticipate.

The parsed SDP object needs an overhaul to make semantic checking and manipulation easier, and the checks for things like stream directionality need to be updated to check SDP semantics instead of syntax.

Comment 1

[Byron Campen [:bwc]]

I've filed bug 1173533, which will likely make some of this bug moot. It would be nice if we could eventually do away with anything that requires inspection or modification to SDP in signaling_unittest.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.