signaling_unittests needs a more flexible SDP representation

REOPENED
Unassigned

Status

()

P5
normal
Rank:
45
REOPENED
5 years ago
a year ago

People

(Reporter: abr, Unassigned)

Tracking

Other Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Right now, a lot of the tests in signaling unittests rely on some rather brittle constructs, such as assuming the order in which SDP sections and attributes appear, and the payload types that will be used in the SDP.

This is very brittle, and results in unnecessary pain whenever the SDP changes in ways the unit tests did not anticipate.

The parsed SDP object needs an overhaul to make semantic checking and manipulation easier, and the checks for things like stream directionality need to be updated to check SDP semantics instead of syntax.

Comment 1

3 years ago
I've filed bug 1173533, which will likely make some of this bug moot. It would be nice if we could eventually do away with anything that requires inspection or modification to SDP in signaling_unittest.
Status: NEW → RESOLVED
backlog: --- → tech-debt
Last Resolved: 3 years ago
Rank: 45
Priority: -- → P4
Resolution: --- → WONTFIX
See Also: → bug 1173533

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
You need to log in before you can comment on or make changes to this bug.