Open Bug 913219 Opened 6 years ago Updated 2 years ago

signaling_unittests needs a more flexible SDP representation

Categories

(Core :: WebRTC: Signaling, defect, P5)

Other Branch
x86
macOS
defect

Tracking

()

REOPENED
Blocking Flags:
backlog tech-debt

People

(Reporter: abr, Unassigned)

References

Details

Right now, a lot of the tests in signaling unittests rely on some rather brittle constructs, such as assuming the order in which SDP sections and attributes appear, and the payload types that will be used in the SDP.

This is very brittle, and results in unnecessary pain whenever the SDP changes in ways the unit tests did not anticipate.

The parsed SDP object needs an overhaul to make semantic checking and manipulation easier, and the checks for things like stream directionality need to be updated to check SDP semantics instead of syntax.
I've filed bug 1173533, which will likely make some of this bug moot. It would be nice if we could eventually do away with anything that requires inspection or modification to SDP in signaling_unittest.
Status: NEW → RESOLVED
backlog: --- → tech-debt
Closed: 4 years ago
Rank: 45
Priority: -- → P4
Resolution: --- → WONTFIX
See Also: → 1173533
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
You need to log in before you can comment on or make changes to this bug.