Closed Bug 913222 Opened 6 years ago Closed 6 years ago

Removing or deplacing apps doesn't work anymore

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:koi+)

VERIFIED FIXED
blocking-b2g koi+

People

(Reporter: fabrice, Assigned: crdlc)

References

Details

(Keywords: regression, smoketest, Whiteboard: [systemsfe])

Attachments

(1 file)

After a long tap on an app, the removable ones get their (x) icon, but there is no animation and the following errors are in logcat:

E/GeckoConsole( 8325): [JavaScript Error: "TypeError: container is undefined" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 144}]
E/GeckoConsole( 8325): [JavaScript Error: "TypeError: draggableIcon is undefined" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 325}]

hitting the home button reverts to standard mode, but also produces this error:

E/GeckoConsole( 8325): [JavaScript Error: "TypeError: page is null" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 228}]
blocking-b2g: --- → koi?
I can reproduce the second error on Buri device using:

Gaia   b6c5bf1d24230bfed4a8f680e625fa2175001f82
SourceStamp 7ff96bd19c1c
BuildID 20130904040205
Version 26.0a1

I am not sure whether Fabrice is reporting using today's build or yesterday's. With the 20130904040205 build I am getting inconsistent behavior when long pressing apps, including some removable apps not showing an x at all when they are long pressed. Eventually after some time the "x" shows up and the animation starts.
To add some additional comments:

(1) If you have only one app and you long press it, at first you see no animation. After about 15 seconds the "x" icon finally appears for me.

(2) If you have more than one app installed, the "x" appears on all the apps but not the app I long press on. There is a delay but eventually the apps start animating.
I try to reproduce with that build but I guess that the error is not in Home app. I could add more info in a couple of hours
or maybe something added recently that when files are minified are wrong...
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1
Regression from bug 893800
Attachment #800635 - Flags: review?(21)
Blocks: 893800
Comment on attachment 800635 [details]
Patch v1

I have no idea if this is going to regress anything :). Let's ask the patch author.
Attachment #800635 - Flags: review?(21) → review?(cjc)
Carmen please take a look to this patch, thanks
Comment on attachment 800635 [details]
Patch v1

I reviewed it on the PR.

What you did shouldn't break anything, but I think just changing

if (value !== undefined) 

with 

if (value || value === 0) would do the same without adding exceptions to the way the descriptors are treated.
Attachment #800635 - Flags: review?(cjc) → review+
Yes, you are right! Please take a look again before landing, thanks a lot
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/a7eac60667fb44eb8e00784bc3af4d745b522ad5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
blocking-b2g: koi? → koi+
Verified - smoketests are passing with the fix here in place.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.