Closed Bug 913407 Opened 11 years ago Closed 11 years ago

rendering issue in Addon manager

Categories

(Core :: Graphics: Layers, defect)

25 Branch
x86_64
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla27
Tracking Status
firefox24 --- unaffected
firefox25 - verified
firefox26 - verified
firefox27 - verified

People

(Reporter: fb+mozdev, Assigned: jrmuizel)

References

Details

(Keywords: regression)

Attachments

(5 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20130905030206

Steps to reproduce:

0. Make sure you have one or more plugins installed. 
1. Open Addon manager. 
2. Switch to "plugins". 
3. Switch to another tab. 
4.a) Switch back to the Addon manager tab. 
4.b) Mouse-hover over a "more" link of a plugin.
4.c) Switch to "Appearance" 


Actual results:

Initially, the "content" background area of the addon manager has a light overlay. 
(a) After switching back and forth between tabs, the background is darker (overlay lost). 
(b) Hovering over "More" shows the background for the link area. 
(c) Switching to "Appearance" shows a part of the background. 

This happens troughout the Addon manager. Aurora 25 is also affected but not Beta 24. 


Expected results:

Background is consistent.
Oh, turning hardware acceleration off via the preferences (NOT about:config) does not change anything. 

HW is a MBA 13" 2012 with Intel HD 4000. 

Most likely a GFX issue (Compositing?).
Hardware: x86 → x86_64
Unfortunately I cannot set the correct params for bug flags. As said in Comment 0, Aurora & Nightly are affected, but not Beta (24).
(sorry for bugspam, I'm done now)
Confirming, also on a 2012 Mac (MacBook Pro).  All you have to do is open about:addons, switch to another tab, switch back, and then notice that the background of the selected about:addons section has changed.  Not sure whether this belongs in some Core component like Graphics or Layout, or Toolkit, so moving to the latter for further investigation.
Status: UNCONFIRMED → NEW
Component: Untriaged → Add-ons Manager
Ever confirmed: true
Product: Firefox → Toolkit
OK I tried this again in Aurora 25, 2013-09-16: Disabling HW accel or OMTC fixes this issue. 

Can someone check if this happens on other platforms than Mac, too?
Blocks: 756601
I just tried UX Nightly (2013-09-17), too, disabling OMTC fixes this issue there, too. 

You can also trigger this by simply reloading (Cmd+R) when in the addons manager.
Component: Add-ons Manager → Graphics: Layers
Product: Toolkit → Core
Firefox 25 Beta 1 through Firefox 27 Nightly 2013-09-24 (all OMTC) are affected now. Nom'ing for tracking.
Matt, can you please see if you can reproduce this on your Mac and if so please find a regression window?
It appears that the first bad build of nightly FF25 is 2013-07-23. The rendering issue presents itself with the steps above, or sometimes just upon first viewing of the add-ons tab.

This is with a Retina MacBook, FWIW.

Let me know if you need more information.
That gives us the following pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2268ff80683a&tochange=5ceea82a79c7

It might be interesting to note that this is the exact same regression range as bug 920044.
Version: 26 Branch → 25 Branch
Matt, if you have the time would you be able to regress this manually by bisecting that range further on your Mac?
Seems a regression from bug 896489.  If I change gfx.content.azure.enabled to false (and restart), the problem goes away.
Blocks: 896489
Flags: needinfo?(jmuizelaar)
Jeff will take this.
Assignee: nobody → jmuizelaar
Flags: needinfo?(jmuizelaar)
We would likely take a low risk uplift, but this is not a critical regression that requires tracking.
Attached patch patchSplinter Review
The original code wasn't handling the case when the gradient line was already completely outside of the extents. This new code handles that and should be more systematic than the previous code.

This is still a little rough but see if you can figure it out and if it makes sense.
Attachment #813476 - Flags: review?(matt.woodrow)
Comment on attachment 813476 [details] [diff] [review]
patch

Review of attachment 813476 [details] [diff] [review]:
-----------------------------------------------------------------

r- for now since I don't understand how it works :)

The patch in bug 902591 seems a lot simpler to understand, and safer since it has testing already.

If you think this approach is superior, then lets work on getting it commented to a level that I can follow when you're back from PTO.

::: gfx/2d/DrawTargetCG.cpp
@@ +401,5 @@
> +  float sin = (end - start).y/length;
> +  Point diff = end - start;
> +
> +  // change the coordinates of the extents box to an axis with start at the origin
> +  // and end in the positive x direction

I really don't understand what this means.

A high level comment explaining what problem this is solving and how it does that would probably help.
Attachment #813476 - Flags: review?(matt.woodrow) → review-
I believe this may have been fixed by bug 902591
Can no longer reproduce on 25b12, 26.0a2 (2013-10-28), 27.0a1 (2013-10-27). Thanks a lot!

(Please resolve as FIXED. I should apply for elevated privileges some time.)
Flags: needinfo?(fb+mozdev)
Thanks for the help, Florian.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Depends on: 902591
Target Milestone: --- → mozilla27
See Also: → 937567
See Also: 937567
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: