913464 - Tabstrip overflow arrow button borders, pinned tab glow, and separators overlap the navbar

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

It looks like fixing bug 908796 now has the tabstrip's arrows' borders overlapping the navbar slightly. Screenshot coming up shortly...

Comment 1

[:Gijs (he/him)]

Attachment: arrow-separator-overlap.png

Comment 2

[Matthew N. [:MattN]]

The pinned tab title change glow also overlaps the nav-bar's top border. Bumping priority since the average user would likely notice the separator issue.

Comment 3

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] from comment #2)
> The pinned tab title change glow also overlaps the nav-bar's top border.
> Bumping priority since the average user would likely notice the separator
> issue.

Testcase: data:text/html;charset=utf-8,<link rel=icon href="http://mail.google.com/favicon.ico"><script>setInterval(function titleUp() { document.title = Date.now();}, 1500)</script>

Comment 4

[Matthew N. [:MattN]]

Attachment: australis pinned tab glow overlapping the nav-bar's top border

Comment 5

[:Gijs (he/him)]

Ideally we should fix this before the merge.

Comment 7

[:Gijs (he/him)]

Attachment: fix everything but the tabs to not overflow,

I feel bad about this patch, but it's the best I could come up with. Pulling up the entire pinned tab using margin-top makes it 'float' when selected, ie then there's a gap at the bottom. This was the best I could come up with. Giving the tab z-index: -1 made it unselectable. :-|

Comment 8

[:Gijs (he/him)]

Note that this patch also means the radial gradient is not 'shining through' the navbar top border as before. I don't see a way to avoid that.

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 831634 [details] [diff] [review]
fix everything but the tabs to not overflow,

Please fix XP as well. I'm fine with a workaround like this for now until we have bug 910987.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

The workaround in bug 908796 which caused this regression has been backed out, so this shouldn't be an issue anymore. Please re-open if this behaviour persists.