913494 - Remove enablePrivilege usage from tests for password manager

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

- Bare nsIObserver didn't work well with SpecialPowers. I replaced it with   SpecialPowers.addObserver/removeObserver.
- Looks like removeObserver is confused by the custom QueryInterface
  implementation on the observer. Fortunately I could just remove it.
- Replaced some instanceof checks with SpecialPowers.call_Instanceof.
- Uncommented a test expecting that enablePrivilege is NOT used.

Feel free to redirect if you think a password manager module owner should review this.

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 800798 [details] [diff] [review]
patch

Review of attachment 800798 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

::: toolkit/components/passwordmgr/test/test_bug_627616.html
@@ +21,5 @@
>        QueryInterface : function (iid) {
>          const interfaces = [Ci.nsIProtocolProxyCallback, Ci.nsISupports];
>  
>          if (!interfaces.some( function(v) { return iid.equals(v) } ))
> +          throw SpecialPowers.wrap(SpecialPowers.Components).results.NS_ERROR_NO_INTERFACE;

SpecialPowers.Cr?

Comment 2

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55e14139d909

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/55e14139d909