Unify how name field is generated across the application

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Contacts
P3
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: Jose Manuel Cantera, Assigned: salva)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [u=commsapps-user c=contacts p=1])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
The name field must be generated uniformly across the application in order to keep maximum consistency
Blocks: 913516
Whiteboard: [u=commsapps-user c=contacts p=3]

Updated

4 years ago
Blocks: 915169

Updated

4 years ago
Blocks: 921977
Created attachment 812179 [details]
Unifying how to produce name field and display name.

The patch is WIP. If you find no regressions, I will add the unit tests for the new `contactField` utility library.
Attachment #812179 - Flags: feedback?(jmcf)
Whiteboard: [u=commsapps-user c=contacts p=3] → [u=commsapps-user c=contacts p=1]
(Reporter)

Comment 2

4 years ago
Salva,

Some relevant comments on GH. I believe the PR needs more work

thanks!
(Reporter)

Updated

4 years ago
Attachment #812179 - Flags: feedback?(jmcf)
Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

All the comments addressed. As said before, once feedback+ I'll add the tests. What do you think now?

Thank you!
Attachment #812179 - Flags: feedback?(jmcf)
(Reporter)

Comment 4

4 years ago
Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

thanks Salva.

You can go ahead with the tests
Attachment #812179 - Flags: feedback?(jmcf) → feedback+
Attachment #812179 - Flags: review?(jmcf)
Thanks to :gitmai for the tests. All is ready for the review JM.
Hi,

just left a comment on github, would like this new script won't affect at all the performance of the app loading.

Ideas are welcome :)
Answered on GitHub. If JM considers this blocking, I'll move it. No problem at all but I tried to support my opinion. No pain at all. Thank you for your feedback.
José Manuel. I'm waiting for your review here. Can you take a look when you are free, please?
Flags: needinfo?(jmcf)
It is rebased. Please, review the patch.
(Reporter)

Comment 10

4 years ago
Hi Salva,

Could you rebase the patch and launch Travis. I would like to merge it for v1.4

thanks
Flags: needinfo?(jmcf)
(Reporter)

Updated

4 years ago
Flags: needinfo?(salva)
Rebased!
Flags: needinfo?(salva)
(Reporter)

Comment 12

4 years ago
Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

not a priority right now for Contacts App
Attachment #812179 - Flags: review?(jmcf)
If this is unimportant, or the code has change enough, we should mark it as wontfix. What do you think?
Flags: needinfo?(jmcf)
(Reporter)

Comment 14

3 years ago
yes, please do it
Flags: needinfo?(jmcf)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.