913507 - Unify how name field is generated across the application

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Jose Manuel Cantera]

The name field must be generated uniformly across the application in order to keep maximum consistency

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Unifying how to produce name field and display name.

The patch is WIP. If you find no regressions, I will add the unit tests for the new `contactField` utility library.

Comment 2

[Jose Manuel Cantera]

Salva,

Some relevant comments on GH. I believe the PR needs more work

thanks!

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

All the comments addressed. As said before, once feedback+ I'll add the tests. What do you think now?

Thank you!

Comment 4

[Jose Manuel Cantera]

Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

thanks Salva.

You can go ahead with the tests

Comment 5

[Salvador de la Puente González [:salva]]

Thanks to :gitmai for the tests. All is ready for the review JM.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

just left a comment on github, would like this new script won't affect at all the performance of the app loading.

Ideas are welcome :)

Comment 7

[Salvador de la Puente González [:salva]]

Answered on GitHub. If JM considers this blocking, I'll move it. No problem at all but I tried to support my opinion. No pain at all. Thank you for your feedback.

Comment 8

[Salvador de la Puente González [:salva]]

José Manuel. I'm waiting for your review here. Can you take a look when you are free, please?

Comment 9

[Salvador de la Puente González [:salva]]

It is rebased. Please, review the patch.

Comment 10

[Jose Manuel Cantera]

Hi Salva,

Could you rebase the patch and launch Travis. I would like to merge it for v1.4

thanks

Comment 11

[Salvador de la Puente González [:salva]]

Rebased!

Comment 12

[Jose Manuel Cantera]

Comment on attachment 812179 [details]
Unifying how to produce name field and display name.

not a priority right now for Contacts App

Comment 13

[Salvador de la Puente González [:salva]]

If this is unimportant, or the code has change enough, we should mark it as wontfix. What do you think?

Comment 14

[Jose Manuel Cantera]

yes, please do it