If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Explosive view never has any explosions in tests

RESOLVED FIXED in 60

Status

Socorro
Webapp
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: peterbe, Assigned: Pwnna)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 800837 [details]
Causes some lacking test coverage

Because of https://github.com/mozilla/socorro/blob/d643d63f35282346e88127d40d93ae4664af541e/webapp-django/crashstats/crashstats/tests/test_views.py#L1879 the explosives() view function never iterates anything on the data.
(Assignee)

Comment 1

4 years ago
PR: https://github.com/mozilla/socorro/pull/1509
Status: NEW → ASSIGNED

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/dab7bd9945151267525528be47f23c4c07c75a71
[Bug 913545] Tests with data for explosive view

Actually have data, also verifies for the correct rendering this time.

https://github.com/mozilla/socorro/commit/46f446a2cfa823781f683cde795ae5720c10b8ec
Merge pull request #1509 from shuhaowu/explosive-view-test-913545

[Bug 913545] Tests with data for explosive view
(Reporter)

Comment 3

4 years ago
Can we resolve this now?
(Assignee)

Comment 4

4 years ago
resolved as is only a unit test change.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → 60
You need to log in before you can comment on or make changes to this bug.