Closed
Bug 913545
Opened 12 years ago
Closed 12 years ago
Explosive view never has any explosions in tests
Categories
(Socorro :: Webapp, task)
Tracking
(Not tracked)
RESOLVED
FIXED
60
People
(Reporter: peterbe, Assigned: shuhao)
Details
Attachments
(1 file)
|
296.03 KB,
image/png
|
Details |
Causes some lacking test coverage
Because of https://github.com/mozilla/socorro/blob/d643d63f35282346e88127d40d93ae4664af541e/webapp-django/crashstats/crashstats/tests/test_views.py#L1879 the explosives() view function never iterates anything on the data.
Status: NEW → ASSIGNED
|
||
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/dab7bd9945151267525528be47f23c4c07c75a71
[Bug 913545] Tests with data for explosive view
Actually have data, also verifies for the correct rendering this time.
https://github.com/mozilla/socorro/commit/46f446a2cfa823781f683cde795ae5720c10b8ec
Merge pull request #1509 from shuhaowu/explosive-view-test-913545
[Bug 913545] Tests with data for explosive view
|
Reporter | |
Comment 3•12 years ago
|
||
Can we resolve this now?
resolved as is only a unit test change.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → 60
You need to log in
before you can comment on or make changes to this bug.
Description
•