913582 - make splinter's display of binary files more obvious

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: Splinter, enhancement, P5)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

File digest1.chunk is missing from https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=904607&attachment=799293 but present in raw view: https://bug904607.bugzilla.mozilla.org/attachment.cgi?id=799293

diff --git a/toolkit/components/url-classifier/tests/unit/data/digest1.chunk b/toolkit/components/url-classifier/tests/unit/data/digest1.chunk
new file mode 100644
index 0000000000000000000000000000000000000000..3850373c19efeca42b55542bd7f9385fbd74e696
GIT binary patch
literal 939
zc$_P?GO{uTA~P-q1_u7Uj0LkA?S9YMZN9CyWtu;SY-!RTr{|nW8Zr(Sim$2dDz-8P
ztF{CymlW?mtNG%1oZ9p|vJrbO%%4;|_t28?2KU5DOPNIt-i{}MYNUK44g`xFoqaZ9
zY5&!|{U<ag#kZ77otXQf+*5#UBVTnSNKGh@+tn>kWiD_2|Mh&&f`}X2b!Bz*)irWM
ztfuZxeh`)cQj@TG>Y~fXv*WpzyOe0pe&;#wc1Ll<(#7&(n;iDtVBFUVa!=l*T{~=*
zSxzynFb@dje!J7`FT0zD@;`C+>a>Vgh06;-<}`Y25PbS0V~WMoaFN*StbT2WN}ej0
zIRxdfdp4L(?$iXC)2F4*nm0L!;X}6No98l9r&a!p-TX9^K}~T_Q=V0zw;@Q)jBu;E
zYM&X*^FBw%nOe9pEt&W}=wR!q)LCkM!e9O|{{z{z?A@8`%QuE^ZPGs%zI^i~(XHvb
zuLykCxfxw6JV!e6PajCl_oy%Shqdy=`MIiZ+}Zia$8*i`^xKd2$9xw`wd*|`eFkLL
z&lIMGEBg2zzSfKlKK^LSt((o~)DE&tn*FkR>67-jXzgMv6GS8`Z~by)|EdqG_q}J?
zKDGK?>s^NaGg<a7ueZ&9COYTJilv;zR;CEmawgxx7tOfZx~%)g8HR&G^WzsK<Sj2=
zeyxLp_3OTXL#2YnR%Rg8h9)K;<pNyEMtjqrSM9pEk3s2X9#dj^W32d+{h=qbRvgUg
z>HcC0RKqp*u%V>-{)Q8i7kFw<`0;G6)Y}4QW<h<Ms@RQ-&-fiK1FB&;5UI3_-E@E1
zr}Ab?fwb2b=SS{8<^6oiWS@zi?RP5~rUBJ(znZ#9`gM$euf+bq&Morg%eKVK&{^V9
zCo_R(?-8}V*Bpzj%n=?DJuLa<pDL$jL^XS)^`4JK`yQ;acUWEj-u1+S>^ZAX&AeG`
zWdRH(1Fm8#ODJt<0Mc%51kx_O?XjTo`>NEb4HNFH=vke8bN`R;!Rt4;*X)xOJvsTP
z@@0^k*Be-(pQIgJ=4#`~tW+d;#Wp42rSO*pou-x-1lW_Vl>v=3M7T&dYVP;t7N!g;
z76<hW|3^l*?Y#f$RP?gF2aJxNe*4_vl^9StQs&dWy|B2le_P)v?+_PZ<;=joq}kI|
RAOAUhTXS3Et?2XB+5jv}i+%tA

Comment 1

[:glob ✱]

binary files don't break splinter - it shows them on the overview page:

# HG changeset patch
# User Monica Chew <[e-mail]>
# Date 1378275224 25200
# Tue Sep 03 23:13:44 2013 -0700
# Node ID c01f44bbd244106eceef10e5e19e342fb21b3249
# Parent e3785e299ab6ea4c4f6f318ff601d73c6be9198c
Bug 904607: Add protocol parser for -digest256 lists (r=gcp).

New Binary File: toolkit/components/url-classifier/tests/unit/data/digest1.chunk

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Please note that digest2.chunk shows up fine, and it is a binary file too. So maybe the bug should be "make splinter's display of binary files consistent and obvious"

Comment 3

[:glob ✱]

digest2.chunk isn't actually a binary patch, it's a normal patch that contains binary data :|

diff --git a/toolkit/components/url-classifier/tests/unit/data/digest1.chunk b/toolkit/components/url-classifier/tests/unit/data/digest1.chunk
new file mode 100644
index 0000000000000000000000000000000000000000..3850373c19efeca42b55542bd7f9385fbd74e696
GIT binary patch
literal 939
(snip)

diff --git a/toolkit/components/url-classifier/tests/unit/data/digest2.chunk b/toolkit/components/url-classifier/tests/unit/data/digest2.chunk
new file mode 100644
--- /dev/null
+++ b/toolkit/components/url-classifier/tests/unit/data/digest2.chunk
@@ -0,0 +1,2 @@
+a:5:32:32
+“Ê_Há^˜aÍ7ÂÙ]´=#ÌnmåÃøún‹æo—ÌQ‰
\ No newline at end of file

Comment 4

[Kohei Yoshino [:kohei]]

Splinter is retiring.