913598 - Electrolysis: Remove failing calls in remote-browser detructor

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tom S. (please needinfo tschuster)]

Attachment: remove-destructor

Both of these just throw an error.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Did you try the two scenarios in bug 895957 comment 24? i.e. does closing a window directly will also throw this error?

And I hadn't noticed webProgress._destroy failing. Is that with the refactor in bug 913280?

Comment 2

[Tom S. (please needinfo tschuster)]

Not really, I will test this. Yeah I missed _destroy in my refactoring.

Comment 3

[Tom S. (please needinfo tschuster)]

So the error with the controller doesn't happen in the case where I close a whole window with remote tabs. And even in the case where I only close a tab, the controller isn't actually null or undefined, but there is still an error. Removing the call seems like the best solution.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Neil, what do you think? can we just remove the call?

Tom, btw if removing all the content you can also remove the destructor block declaration

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 800885 [details] [diff] [review]
remove-destructor

Markh says this is causing some test failures, so let's just do it and if we need to add the removeController back we'll do it.
Please remove the whole <destructor> declaration

Comment 6

[Tom S. (please needinfo tschuster)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d3bc67971a

Comment 7

[[e-mail]]

As far as I can tell all of this stuff should get automatically cleaned up once the <browser> is removed from the DOM and dereferenced and so you should be OK not to manually remove it.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d8d3bc67971a