913633 - platform.js miscategorizes FF for Android and Firefox OS browsers

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Mike Taylor [:miketaylr]]

> platform.parse("Mozilla/5.0 (Android; Mobile; rv:23.0) Gecko/23.0 Firefox/23.0")
{ version: '23.0',
  name: 'Android Browser',
  os: 
   { architecture: 32,
     family: 'Android',
     version: null,
     toString: [Function] },
  description: 'Android Browser 23.0 (Gecko)',
  layout: 'Gecko',
  manufacturer: null,
  prerelease: null,
  product: null,
  ua: 'Mozilla/5.0 (Android; Mobile; rv:23.0) Gecko/23.0 Firefox/23.0',
  parse: [Function: parse],
  toString: [Function: toStringPlatform] }
> platform.parse("Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0")
{ version: '18.0',
  name: 'Firefox Mobile',
  os: 
   { architecture: null,
     family: null,
     version: null,
     toString: [Function] },
  description: 'Firefox Mobile 18.0',
  layout: 'Gecko',
  manufacturer: null,
  prerelease: null,
  product: null,
  ua: 'Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0',
  parse: [Function: parse],
  toString: [Function: toStringPlatform] }

Comment 1

[Mike Taylor [:miketaylr]]

Filed https://github.com/bestiejs/platform.js/issues/26 and https://github.com/bestiejs/platform.js/issues/27. Will work on pull requests + tests in a bit.

Comment 2

[Mike Taylor [:miketaylr]]

Took a while to digest the code, but here's a PR for Firefox for Android, https://github.com/bestiejs/platform.js/pull/28

Firefox OS shouldn't be too much work to add, will work on that tomorrow.

Comment 3

[Mike Taylor [:miketaylr]]

And the PR for FxOS https://github.com/bestiejs/platform.js/pull/30

Comment 4

[Hallvord R. M. Steen [:hallvors]]

For some reason those two bugs on Github seem closed but the pull requests seem like they are not taken..? Pinging him on github.

Comment 5

[Mike Taylor [:miketaylr]]

Yeah I bug John David Dalton (the maintainer) every once in a while on IRC. I guess he'll find the time at some point...

Comment 6

[Hallvord R. M. Steen [:hallvors]]

I think [sitewait] would be appropriate - if only to get it out of my todo-list ;)

Comment 7

[Mike Taylor [:miketaylr]]

> f.parse('Mozilla/5.0 (Mobile; LG-D300; rv:18.1) Gecko/18.1 Firefox/18.1')
{ version: '18.1',
  name: 'LG Browser',
  os: 
   { architecture: null,
     family: null,
     version: null,
     toString: [Function] },
  description: 'LG Browser 18.1 (Gecko) on LG',
  layout: 'Gecko',
  manufacturer: 'LG',
  prerelease: null,
  product: 'LG',
  ua: 'Mozilla/5.0 (Mobile; LG-D300; rv:18.1) Gecko/18.1 Firefox/18.1',
  parse: [Function: parse],
  toString: [Function: toStringPlatform] }

That needs to be fixed as well.

Similar results for tablet uas:

> f.parse('Mozilla/5.0 (Android; Tablet; rv:26.0) Gecko/26.0 Firefox/26.0')
{ version: '26.0',
  name: 'Android Browser',
  os: 
   { architecture: 32,
     family: 'Android',
     version: null,
     toString: [Function] },
  description: 'Android Browser 26.0 (Gecko)',
  layout: 'Gecko',
  manufacturer: null,
  prerelease: null,
  product: null,
  ua: 'Mozilla/5.0 (Android; Tablet; rv:26.0) Gecko/26.0 Firefox/26.0',
  parse: [Function: parse],
  toString: [Function: toStringPlatform] }
> f.parse('Mozilla/5.0 (Tablet; rv:26.0) Gecko/26.0 Firefox/26.0')
{ version: '26.0',
  name: 'Firefox',
  os: 
   { architecture: null,
     family: null,
     version: null,
     toString: [Function] },
  description: 'Firefox 26.0',
  layout: 'Gecko',
  manufacturer: null,
  prerelease: null,
  product: null,
  ua: 'Mozilla/5.0 (Tablet; rv:26.0) Gecko/26.0 Firefox/26.0',
  parse: [Function: parse],
  toString: [Function: toStringPlatform] }

Comment 8

[Mike Taylor [:miketaylr]]

(I need to revisit my patch.)

Comment 9

[Mike Taylor [:miketaylr]]

Both PRs merged. Thanks!