Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: brett, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Popcorn Maker should know what size it is in and adjust
(Reporter)

Comment 1

5 years ago
moving off mozfest
Whiteboard: mozfest
(Assignee)

Comment 2

5 years ago
Created attachment 830434 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/312

Almost there with completely dynamic sizes.

Just need to solve the part inside make-valet.

This method now ensures the whole video is visible, not matter the height and width, keeps aspect ratio, and is as large as it can be.
Attachment #830434 - Flags: review?(schranz.m)
(Assignee)

Comment 3

5 years ago
My plan is to fix the make-valet in bug 888293 or file a new one.
(Assignee)

Comment 4

5 years ago
Had to push up a small patch on this where a class video was being set on both the video and the video-container, which in the editor is not so.

Changing this in the markup only solves it for new projects, so I also changed the css to use id instead of class which is correclty placed.
Lint is failing a whole bunch in this patch.

Also, looks like LESS linting doesn't pick up on unused vars. I imagine a lot of https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/css/globals.less#L208-L238 can be removed, although perhaps not all of it.
Attachment #830434 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 6

5 years ago
Comment on attachment 830434 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/312

Updated.

I made it an object after all. Perf is better, I can do one setup, and store the calues, then the resize function is much smaller.

Removed the dead less you noticed, I forgot about it.

I also fixed lint.
Attachment #830434 - Flags: review- → review?(schranz.m)
Comment on attachment 830434 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/312

Sadly removing the CSS from the embed-shell is going to be a bad idea for people running things via Webmaker Suite. If you aren't running the make-valet, removing that code causes our embeds to break/look terrible.

For you or I, I think it's reasonable to say "Go run the Make-valet" but for everyone else it isn't. The make-valet does spin up with the webmaker-suite but it still requires people to manually make those config changes for user subdomains. It also isn't flipped on by default in the configs.
Attachment #830434 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 8

5 years ago
Comment on attachment 830434 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/312

Yeah, didn't think we still supported it. Updated.
Attachment #830434 - Flags: review- → review?(schranz.m)
Attachment #830434 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 9

5 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/fbb9242a2735eb4fd420b832d295233db3e7d350

Needs verification.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.