913761 - Something is wrong when transferring MessagePort object via MessageChannel

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[SUN Haitao]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20130903144150

Steps to reproduce:

0 Make sure 'dom.messageChannel.enabled' is set to true;
1 Open Scratchpad
2 Run the following code:
    var transportChannel = new MessageChannel();
    transportChannel.port1.onmessage = function (event) {
      console.log('Port Returned.');
      var portToService = (event.ports || event.data.ports)[0];
      portToService.onmessage = function (event) {
        console.log(event.data);
      };
      portToService.postMessage('READY?');
    }
    
    var serviceChannel = new MessageChannel();
    serviceChannel.port1.onmessage = function (event) {
      if (event.data == 'READY?') {
        this.postMessage('READY!');
      }
    }
    
    //Actually, this should be (See Bug 912456):
    //transportChannel.port2.postMessage(null, [serviceChannel.port2]);
    transportChannel.port2.postMessage({ports:[serviceChannel.port2]});



Actual results:

Only 'Port Returned.' is printed in console.



Expected results:

Both 'Port Returned.' and 'READY!' are printed.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Thanks for this bug and the piece of code for reproducing it.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 801096 [details] [diff] [review]
patch

Could we someone guarantee that Cloned port without owner window isn't
ever used by JS?
Perhaps add a method to nsDOMEventTargetHelper which sets
mHasOrHasHadOwner to true and call it in Clone()

Comment 3

[Ryan VanderMeulen (PTO, back 6-April)]

(Yet another) reminder - your commit message should say what your patch is doing, not restating the bug summary.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1585fa81edfc

Comment 4

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/1585fa81edfc