Closed
Bug 913811
Opened 11 years ago
Closed 11 years ago
HTTP cache v2: store frecency to cache entries
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
DUPLICATE
of bug 924116
People
(Reporter: mayhemer, Assigned: mayhemer)
Details
(Whiteboard: [cache2])
Attachments
(1 file, 2 obsolete files)
7.83 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
I think of adding a new specialized properties to CacheFileMetadata beside Set/GetExpirationTime.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8336185 -
Flags: review?(michal.novotny)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8336846 -
Flags: review?(michal.novotny)
Comment 3•11 years ago
|
||
Comment on attachment 8336846 [details] [diff] [review]
v2 (persist as int)
Review of attachment 8336846 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/cache2/CacheEntry.cpp
@@ +337,5 @@
>
> + uint32_t frecency;
> + mFile->GetFrecency(&frecency);
> + // mFrecency is held in a double to increase computance precision.
> + // It is ok to persist frecency only as a float (single precision).
float -> uint32_t
Attachment #8336846 -
Flags: review?(michal.novotny) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks.
I'll land this after I have a plan for the frecency decay time decision testing patch (bug 924116).
Attachment #8336185 -
Attachment is obsolete: true
Attachment #8336846 -
Attachment is obsolete: true
Attachment #8336185 -
Flags: review?(michal.novotny)
Attachment #8336864 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 5•11 years ago
|
||
This should land together with bug 924116.
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•