Closed Bug 913890 Opened 6 years ago Closed 6 years ago

Remove unused BrowserApp.getActionBarLayout (again)

Categories

(Firefox for Android :: Awesomescreen, defect, trivial)

ARM
Android
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: ckitching, Assigned: ckitching)

References

Details

Attachments

(1 file)

Stumbled across:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java#974

while doing actual work.

This appears to be defunct now the new about:home has arrived. (And nothing bad happens when I delete it, my IDE claims it's dead code, and Proguard deletes it. It's probably dead.)
Attached patch Clean it upSplinter Review
Trivial patch to clean this up.
Attachment #801196 - Flags: review?(margaret.leibovic)
Comment on attachment 801196 [details] [diff] [review]
Clean it up

Review of attachment 801196 [details] [diff] [review]:
-----------------------------------------------------------------

This code isn't in aurora/beta/release, so it's probably just some artifact of a bad merge. It was actually removed originally in bug 869411. Nice catch.
Attachment #801196 - Flags: review?(margaret.leibovic) → review+
Blocks: 869411
Summary: Leftover dead code from AwesomeBar discovered. → Remove unused BrowserApp.getActionBarLayout (again)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75098ad2784b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.