Closed
Bug 913890
Opened 12 years ago
Closed 12 years ago
Remove unused BrowserApp.getActionBarLayout (again)
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: ckitching, Assigned: ckitching)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Stumbled across:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java#974
while doing actual work.
This appears to be defunct now the new about:home has arrived. (And nothing bad happens when I delete it, my IDE claims it's dead code, and Proguard deletes it. It's probably dead.)
|
Assignee | |
Comment 1•12 years ago
|
||
Trivial patch to clean this up.
Attachment #801196 -
Flags: review?(margaret.leibovic)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 801196 [details] [diff] [review]
Clean it up
Review of attachment 801196 [details] [diff] [review]:
-----------------------------------------------------------------
This code isn't in aurora/beta/release, so it's probably just some artifact of a bad merge. It was actually removed originally in bug 869411. Nice catch.
Attachment #801196 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Updated•12 years ago
|
Blocks: 869411
Summary: Leftover dead code from AwesomeBar discovered. → Remove unused BrowserApp.getActionBarLayout (again)
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•