913920 - Implement HTMLFormControlsCollection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Rename nsFormControlList and move it to its own files

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Implement HTMLFormControlsCollection and use it for HTMLFormElement.elements

Comment 3

[David Zbarsky (:dzbarsky)]

Comment on attachment 810713 [details] [diff] [review]
Part a: Rename nsFormControlList and move it to its own files

Review of attachment 810713 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLFormControlsCollection.cpp
@@ +75,2 @@
>  {
>    SetIsDOMBinding();

If you're doing this can you also change the colon to be on the next line?  Seems odd otherwise.

::: content/html/content/src/HTMLFormElement.cpp
@@ +979,2 @@
>  {
>    NS_ASSERTION(aElement1 != aElement2, "Comparing a form control to itself");

Why are you changing these?

Comment 4

[David Zbarsky (:dzbarsky)]

Comment on attachment 810714 [details] [diff] [review]
Part b: Implement HTMLFormControlsCollection and use it for HTMLFormElement.elements

Review of attachment 810714 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLFormControlsCollection.cpp
@@ +375,5 @@
> +  if (nsCOMPtr<Element> element = do_QueryInterface(item)) {
> +    aResult.SetValue().SetAsElement() = element;
> +    return;
> +  }
> +  if (nsCOMPtr<nsINodeList> nodelist = do_QueryInterface(item)) {

This seems a little sad, but I guess you have to implement nsIHTMLCollection?

::: content/html/content/test/test_formelements.html
@@ +50,5 @@
>  is(names[7], "y", "Entry 8")
>  is(names[8], "z", "Entry 9")
>  is(names[9], "something", "Entry 10")
> +is(names[10], "namedItem", "Entry 11")
> +is(names[11], "item", "Entry 12")

OOC, what determines the order here?

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to David Zbarsky (:dzbarsky) from comment #4)
> Comment on attachment 810714 [details] [diff] [review]
> Part b: Implement HTMLFormControlsCollection and use it for
> HTMLFormElement.elements
> 
> Review of attachment 810714 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/html/content/src/HTMLFormControlsCollection.cpp
> @@ +375,5 @@
> > +  if (nsCOMPtr<Element> element = do_QueryInterface(item)) {
> > +    aResult.SetValue().SetAsElement() = element;
> > +    return;
> > +  }
> > +  if (nsCOMPtr<nsINodeList> nodelist = do_QueryInterface(item)) {
> 
> This seems a little sad, but I guess you have to implement nsIHTMLCollection?
> 
> ::: content/html/content/test/test_formelements.html
> @@ +50,5 @@
> >  is(names[7], "y", "Entry 8")
> >  is(names[8], "z", "Entry 9")
> >  is(names[9], "something", "Entry 10")
> > +is(names[10], "namedItem", "Entry 11")
> > +is(names[11], "item", "Entry 12")
> 
> OOC, what determines the order here?

I think it walks the proto chain, and then... something.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d1ff09ace32b
https://hg.mozilla.org/mozilla-central/rev/0779196218d2

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to David Zbarsky (:dzbarsky) from comment #3)
> Comment on attachment 810713 [details] [diff] [review]
> Part a: Rename nsFormControlList and move it to its own files
> 
> Review of attachment 810713 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/html/content/src/HTMLFormElement.cpp
> @@ +979,2 @@
> >  {
> >    NS_ASSERTION(aElement1 != aElement2, "Comparing a form control to itself");
> 
> Why are you changing these?

Seems like I never answered this; because those functions are called from both HTMLFormElement.cpp and HTMLFormControlsCollection.cpp now.

Comment 8

[Jean-Yves Perrier [:teoli]]

Reverting the target milestone as I believe it was removed by error. (and Ms2ger not on IRC to double-check). Remove it again if I'm mistaken.

Comment 9

[Jean-Yves Perrier [:teoli]]

Doc updated:
https://developer.mozilla.org/en-US/Firefox/Releases/27
https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormControlsCollection
https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormControlsCollection.namedItem