913967 - Build tier changes broke comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

There are at least three separate issues breaking comm-central right now:

1. One of glandium's several changes broke the proper building of LDAP code.
2. The code tries to "make compile" in c-c, which breaks, obviously.

The third is a windows-specific build which looks unrelated to the fixes needed to get Linux and OS X working, so that will get its own bug.

Comment 2

[Joshua Cranmer [:jcranmer]]

Attachment: Fix the build

I didn't feel justified landing this with an r=bustage-fix port, since there is a slight modification to get LDAP working properly.

Comment 3

[Hartmut Figge]

(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> Created attachment 801574 [details] [diff] [review]
> Fix the build

The fix works for me. But. *g* Now there is again a previous one

processing /home/hafi/moz-work/src/mozilla/extensions/irc/sm/jar.mn
Packaging chatzilla-0.9.90.1.xpi...
cd ../../../dist/xpi-stage/chatzilla && /usr/bin/zip -qr ../chatzilla-0.9.90.1.xpi *
rm -f -r "../../../dist/bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}"
/home/hafi/moz-work/src/obj-x86_64-unknown-linux-gnu/mozilla/config/nsinstall -D "../../../dist/bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}"
(cd ../../../dist/xpi-stage/chatzilla/. && tar -chf - .) | (cd ../../../dist/bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/. && tar -xf -)
make[7]: Leaving directory `/home/hafi/moz-work/src/obj-x86_64-unknown-linux-gnu/mozilla/extensions/irc/sm'
make[6]: Leaving directory `/home/hafi/moz-work/src/obj-x86_64-unknown-linux-gnu/mozilla/extensions/irc'
make[5]: Leaving directory `/home/hafi/moz-work/src/obj-x86_64-unknown-linux-gnu/mozilla/extensions'
make[4]: *** [libs] Error 2

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 801574 [details] [diff] [review]
Fix the build

Review of attachment 801574 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 5

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/f4c921623a74

Comment 6

[Frank Wein [:mcsmurf]]

(In reply to Hartmut Figge from comment #3)
> (In reply to Joshua Cranmer [:jcranmer] from comment #2)
> > Created attachment 801574 [details] [diff] [review]
> > Fix the build
> 
> The fix works for me. But. *g* Now there is again a previous one
> 
> processing /home/hafi/moz-work/src/mozilla/extensions/irc/sm/jar.mn
> Packaging chatzilla-0.9.90.1.xpi...
[...]

Can you file a new bug for this? I think this needs to be fixed to get SeaMonkey trunk compiling again.

Comment 7

[Sladky Vladimir]

I have too new bug:

Packaging venkman-0.9.89.xpi...
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1521:0$ cd ../../dist/xpi-stage/venkman && zip -qr ../venkman-0.9.89.xpi *

zip error: Nothing to do! (try: zip -qr ../venkman-0.9.89.xpi . -i *)
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1521:0: command 'cd ../../dist/xpi-stage/venkman && zip -qr ../venkman-0.9.89.xpi *' failed, return code 12
evaluation from c:\Users\Vlada\comm-central\mozilla\config\recurse.mk:44:44:7:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py -C venkman libs' failed, return code 2

Comment 8

[Frank Wein [:mcsmurf]]

I filed bug 914560 on the Venkman issue.

Comment 9

[Tony Mechelynck [:tonymec]]

SeaMonkey builds are now being produced again for W32, L32 and L64. Not for the Mac but the error has changed: it seems to have something to do with packaging the omnijar.

This hourly that I'm using is the latest L64 build as of this writing:
Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 SeaMonkey/2.23a1 ID:20130912192824 c-c:303c7574e706 m-c:b9029b1de410
No nightlies yet.

Comment 10

[Mark Banner (:standard8)]

As have been already requested, please file separate bugs for different errors rather than commenting on closed bugs - in this case its likely to be different especially as Thunderbird trunk is now building (and it was a separate bug that fixed the TB builds).

Comment 11

[Frank Wein [:mcsmurf]]

Indeed, Bug 914560 takes care of SeaMonkey issues (didnt I mention this before :).