913970 - [mozrunner] mozrunner cleanup from mochitest on mozbase

Status: RESOLVED INACTIVE

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

A number of small API defects were encountered in the tackling of
bug 746243: getting mochitest on mozrunner/mozprocess:

* [mozrunner] debuggers and debugger_args should be be added to __all__
  -> already ticketed as Bug 913217 -

- [mozrunner] Runner.wait() should return status code
  In fact, the stdout, the returncode, and whether the process has
  timed out and any other state stored in the mozprocess process
  handler are simply discarded with the process_handler object in this method

- [mozrunner] Runner should front-end stdout, stderr (, etc)
  Related to the above: e.g. stdout should have a method, say 'output'
  in the runner class for retrieval.  Similarly, for if the process
  times out.

* [mozrunner] mozrunner cleanup should only selectively kill the process:
"""
Traceback (most recent call last):
  File
  "/home/jhammel/mozilla/src/obj-browser/_tests/testing/mochitest/runtests.py",
  line 780, in runTests
    onLaunch=onLaunch
  File
  "/home/jhammel/mozilla/src/obj-browser/_tests/testing/mochitest/runtests.py",
  line 683, in runApp
    env=env, processOutputLine=self.processOutputLine)
  File
  "/home/jhammel/mozilla/src/mozilla-central/testing/mozbase/mozrunner/mozrunner/local.py",
  line 214, in __init__
    LocalRunner.__init__(self, profile, binary, **kwargs)
TypeError: __init__() got an unexpected keyword argument
'processOutputLine'
Mochitest ERROR | runtests.py | Received unexpected exception while
running application

 0:01.91 WARNING | leakcheck | refcount logging is off, so leaks can't
 be detected!
Mochitest INFO  | runtests.py | Running tests: end.
Exception AttributeError: "'FirefoxRunner' object has no attribute
 'process_handler'" in <bound method FirefoxRunner.cleanup of
 <mozrunner.local.FirefoxRunner object at 0xa48a68c>> ignored
"""

All of these should only be a few lines of code.  They could be
ticketed and tackled separately if desired.

Comment 1

[Jeff Hammel]

> - [mozrunner] Runner.wait() should return status code In fact, the
> stdout, the returncode, and whether the process has timed out and
> any other state stored in the mozprocess process handler are simply 
> discarded with the process_handler object in this method

The returncode was taken with bug 915866