914075 - [System] ril.data.apnSettings cannot be either null or empty

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

If the apn.json database doesn't have APN settings for the MCC and MNC codes in the SIM the `ril.data.apnSettings` could be empty causing the RIL not being able to set up data calls. Since most carriers allow data call with empty APN name, user, password, etc. settings we should provide a default value for `ril.data.apnSettings` setting with empty values for the APN settings we need in the RIL plumbing.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Ken, just noticed we have an issue we should fix. Could you read comment #0 and confirm the issue please? Thanks!

Comment 2

[Ken Chang[:kenkai]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)
> If the apn.json database doesn't have APN settings for the MCC and MNC codes
> in the SIM the `ril.data.apnSettings` could be empty causing the RIL not
> being able to set up data calls. Since most carriers allow data call with
> empty APN name, user, password, etc. 
May I know which carriers will dial data call with empty APN name?

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Ken Chang from comment #2)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)

> May I know which carriers will dial data call with empty APN name?

Sure, Movistar (Telefonica Spain) and I guess Tuenti one of its MVOs, but sadly I don't have a list.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Actually the bug here is that if the apn.json database doesn't have APN settings for the MCC and MNC codes in the SIM the `ril.data.apnSettings` could be empty causing the RIL not being able to set up data calls.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Ken Chang from comment #2)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)
> > If the apn.json database doesn't have APN settings for the MCC and MNC codes
> > in the SIM the `ril.data.apnSettings` could be empty causing the RIL not
> > being able to set up data calls. Since most carriers allow data call with
> > empty APN name, user, password, etc. 
> May I know which carriers will dial data call with empty APN name?

Even It's allowed to set up data calls with null values for apn, user, and password parameters. See https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L1547-1550

Comment 6

[Ken Chang[:kenkai]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #5)
> Even It's allowed to set up data calls with null values for apn, user, and
> password parameters. See
> https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/
> telephony/ril.h#L1547-1550
The comments say, "...this APN will override the one in the profile. NULL indicates no APN overrride."
It doesn't say it can accept the null APN. But if some carriers use the NULL APN, we have to handle it.

Comment 7

[Ken Chang[:kenkai]]

Do you want to handle this issue?

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

I'm able to set up data calls with the SIM card provided by Telenor without providing values for apn, user and password APN settings. Although that works (and could work with other carries as well) I don't see user settings those APN settings (apn, user, and password) to null. If there is no APN settings for the MCC and MNC codes in the SIM `ril.data.apnSettings` setting will be `[[]]` and data calls cannot work but the user could set the APN settings for that SIM in the setting app and enable them.

I'll resolve this bug as WORKSFORME and let's reopen it in the future if we need to handle it.

Thanks Ken for your feedback.