Closed
Bug 914152
Opened 12 years ago
Closed 12 years ago
[B2G][CDMA][Gaia] To have a setting to enable/disable short DTMF.
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kchang, Assigned: arthurcc)
References
Details
Attachments
(1 file)
We need to have a setting to enable or disable short DTMF for CDMA feature.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → arthur.chen
|
Assignee | |
Comment 1•12 years ago
|
||
Evelyn, could you help review this patch? This function is only enabled when the phone supports CDMA. Thus I add an utility function for checking CDMA things. I did not rewrite other parts of checking CDMA in this patch. Please let me know if you think it is needed, thanks!
Attachment #802883 -
Flags: review?(ehung)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 802883 [details]
link to https://github.com/mozilla-b2g/gaia/pull/12107
r=me, yes please remove the redundant code and use your utility function for checking CDMA supported instead. I'd like to take a look again after you updated.
Attachment #802883 -
Flags: review?(ehung)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 802883 [details]
link to https://github.com/mozilla-b2g/gaia/pull/12107
Patch updated, could you help take a look at it again? Thanks!
Attachment #802883 -
Flags: review?(ehung)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 802883 [details]
link to https://github.com/mozilla-b2g/gaia/pull/12107
r=me, the patch is good, thank you.
Attachment #802883 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•