914191 - [Contacts] Import contacts from SD card make phone not enter sleep.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Version: Gaia master
Steps to reproduce:

1. Inserd SD(not include contacts file,vcf vfile) to phone;
2. Press power key to turn on phone;
3. Enter contacts menu,select "import contacts from SIM Card of Facebook";
4. Select from SD ;
5. Appear prompt box "Could not import contacts from SD card",beacause of no vcf file in sd card;
6. Press "Cancel" button,then touch  home button ,return to idle;
7. Pres power key ;

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Adding the regression keyword here since we fixed the problem in 1.1, but not 1.2.

Gary, are you still working on this?

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

ni? gary for comment 1

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Sorry, I am still busy on system platform koi+,
If anyone available please feel free to take this bug.
   
Thanks

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

In hindsight I regret allowing the v1-train patch to move forward without the fix landing on master in bug 908545.  That bug should really have been kept open until this was resolved.  I believe the only thing that needs to be done here is add a unit test to prevent breakage in the future.  If that is super difficult for some reason, then lets just land the fix as provided in bug 908545.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, this one totally felt from y radar.

Taking care of it and adding a bit of love, will sync with Ben as he seems to be knowing the details happening around here.

Thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

After syncing with Ben, what I'll get the patch for master from bug 908545, will need to rebase it and add the unit test.

Thanks,
F.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 12656

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 813574 [details]
Pointer to PR 12656

Awesome.  Thanks!

I verified that the new tests fail if I comment out the resetWait(wakeLock) call.

Thanks again for taking this on.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/12d41a0c09531ac8b527b71edaa4daada7b08e9d

Comment 10

[Anthony Ricaud (:rik)]

And backed out :( de6b143ed823fc195c8a802ed4f833cc88d489ba

Because of the following errors:
1) [communications-contacts] Contacts settings SD Card import SD Import went well:
 TypeError: utils.sdcard.retrieveFiles is not a function
at onSdImport (http://communications.gaiamobile.org:8080/contacts/js/views/settings.js:671)
at (anonymous) (http://communications.gaiamobile.org:8080/contacts/test/unit/views/settings_test.js:163)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979)
at done (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:46)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:73)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

2) [communications-contacts] Contacts settings SD Card import SD Import with error cause no files to import:
ReferenceError: Exception is not defined
at MockWakeLock (http://communications.gaiamobile.org:8080/contacts/test/unit/mock_wakelock.js:7)
at onSdImport (http://communications.gaiamobile.org:8080/contacts/js/views/settings.js:660)
at (anonymous) (http://communications.gaiamobile.org:8080/contacts/test/unit/views/settings_test.js:174)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979)
at done (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:46)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:73)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 11

[Anthony Ricaud (:rik)]

Please be mindful of the modification in mock_wakelock.js from bug 917582 when re-landing this.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Thanks :rik for backing out, it's a bit weird, each time that I run it locally, all the contacts suite I get the following:

506 tests complete (18 seconds)

All of them passing, will launch a PR again (with the fixed in bug 917582), and lets see what travis tells me.

Thanks again!

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

move to v1.2 C3

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 12752

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 819149 [details]
Pointer to PR 12752

><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/12752"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/12752">https://github.com/mozilla-b2g/gaia/pull/12752</a>, or wait 5 seconds to be redirected there automatically.</p>

Comment 16

[Ben Kelly [:bkelly, not reviewing]]

Hmm, that didn't work.  The attachment is redirecting to the wrong pull request.  It is going to 12756 instead of 12752 as said in the attachment summary.  Going to review this:

  https://github.com/mozilla-b2g/gaia/pull/12752

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Ouch, the correct PR is this one: PR 12752

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Attachment updated, thanks!

Comment 19

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 819149 [details]
Pointer to PR 12752

r=me for pull request 12752 (don't think this was updated to redirect correctly).  There are a couple nits on GH.  The tests pass locally, but please make sure travis is green before landing.

Thanks!

Comment 20

[Francisco Jordano [:arcturus] [:francisco]]

So far, the unit test are passing, but the ui test are not.

Wonder if this is a known issue and I should merge.


https://travis-ci.org/mozilla-b2g/gaia/builds/12753402

Very tempted to merge :S

Comment 21

[Ben Kelly [:bkelly, not reviewing]]

I haven't seen this before and it's in contacts:

Traceback (most recent call last):

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.6.0-py2.7.egg/marionette/marionette_test.py", line 123, in run

self.setUp()

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_add_contact_to_favorites.py", line 16, in setUp

self.data_layer.insert_contact(self.contact)

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 159, in insert_contact

result = self.marionette.execute_async_script('return GaiaDataLayer.insertContact(%s);' % json.dumps(contact), special_powers=True)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.6.0-py2.7.egg/marionette/marionette.py", line 1073, in execute_async_script

filename=os.path.basename(frame[0]))

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.6.0-py2.7.egg/marionette/marionette.py", line 577, in _send_message

self._handle_error(response)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.6.0-py2.7.egg/marionette/marionette.py", line 612, in _handle_error

raise JavascriptException(message=message, status=status, stacktrace=stacktrace)

JavascriptException: TypeError: contact.init is not a function

stacktrace:

execute_async_script @gaia_test.py, line 159

inline javascript, line 397

src: " contact.init(aContact);"

TEST-UNEXPECTED-FAIL | test_add_contact_to_favorites.py test_add_contact_to_favorites.TestAddContactToFavorite.test_add_contact_to_favorite

Comment 22

[Ben Kelly [:bkelly, not reviewing]]

It seems this is failing:

  var c = new mozContact();
  c.init(params);

With init() not being a function.

Reuben, do you think this could be related to your webidl changes that recently landed?

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

I realised that ui test is also failing in other builds:

https://travis-ci.org/mozilla-b2g/gaia/jobs/12744888

Comment 24

[Francisco Jordano [:arcturus] [:francisco]]

As per conversation on IRC, we will merge this bug, as unit tests are passing and the error that we see in the gaia ui tests is happening without this PR as well.

Comment 25

[Francisco Jordano [:arcturus] [:francisco]]

Landend:

https://github.com/mozilla-b2g/gaia/commit/0b28ac489ddf484468bb1df336b81ae9421bf1fd

Comment 26

[Reuben Morais [:reuben]]

(In reply to Ben Kelly [:bkelly] from comment #22)
> Reuben, do you think this could be related to your webidl changes that
> recently landed?

Yes. I'll land my PR.

Comment 27

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0b28ac489ddf484468bb1df336b81ae9421bf1fd to:
v1.2: c7f75ad29da127cd27690eeafcf5d7d008ad1c87