Uncaught exception when creating a new tab

RESOLVED FIXED in Firefox 28

Status

Firefox for Metro
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ally, Assigned: gbleaney)

Tracking

unspecified
Firefox 28
x86_64
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=TimAbraldes][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
uncaught exception: Not Loading!
endLoading@chrome://browser/content/browser.js:1570
_networkStop@chrome://browser/content/WebProgress.js:152
receiveMessage@chrome://browser/content/WebProgress.js:47

browser appears to start normally
Went to file this but found the existing bug. Update on the exception message:
  uncaught exception: Not Loading!
  endLoading@chrome://browser/content/browser.js:1318
  _networkStop@chrome://browser/content/WebProgress.js:136
  receiveMessage@chrome://browser/content/WebProgress.js:45
Looks like |endLoading| is being called but |startLoading| was never called:
  https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/browser.js?r=ba2e9f9f2991#1316

This seems to be happening each time a new tab is opened. Perhaps it is just normal operation for |startLoading| not to be called when a new tab is created?
Summary: Uncaught exception during startup on Nightly → Uncaught exception during startup
Summary: Uncaught exception during startup → Uncaught exception when creating a new tab
Yes, this has been around forever and I don't think it indicates a real problem.  I think we should just remove this check and not throw an exception.
Marking as a mentored bug, in case a new contributor wants to jump in before one of us happens to fix this :)
Whiteboard: [good first bug][mentor=TimAbraldes][lang=js]
gbleaney has expressed interest in taking a stab at this issue.

gbleaney: As you mentioned, removing the check/exception from the |endLoading| function in browser.js is the way to start. Then verify that the function still works as expected... and, of course, that the error no longer appears in the error console :)
Assignee: nobody → gbleaney
Status: NEW → ASSIGNED
(Assignee)

Comment 6

4 years ago
Created attachment 8335077 [details] [diff] [review]
bug914278_removedCheckAndException.diff
Attachment #8335077 - Flags: review?(tabraldes)
Comment on attachment 8335077 [details] [diff] [review]
bug914278_removedCheckAndException.diff

Review of attachment 8335077 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I applied the patch and tested on various websites (which I assume gbleaney did as well).

gbleaney - let me know if you need help landing this, or if you don't have commit access yet (in which case I'll land this for you)
Attachment #8335077 - Flags: review?(tabraldes) → review+
Setting checkin-needed: This can be landed along with other changes. No need to tax our builders by having them make builds with just this changeset.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/1c86cdf8df86
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=TimAbraldes][lang=js] → [good first bug][mentor=TimAbraldes][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1c86cdf8df86
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=TimAbraldes][lang=js][fixed-in-fx-team] → [good first bug][mentor=TimAbraldes][lang=js]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.