914278 - Uncaught exception when creating a new tab

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Allison Naaktgeboren :ally]

uncaught exception: Not Loading!
endLoading@chrome://browser/content/browser.js:1570
_networkStop@chrome://browser/content/WebProgress.js:152
receiveMessage@chrome://browser/content/WebProgress.js:47

browser appears to start normally

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Went to file this but found the existing bug. Update on the exception message:
  uncaught exception: Not Loading!
  endLoading@chrome://browser/content/browser.js:1318
  _networkStop@chrome://browser/content/WebProgress.js:136
  receiveMessage@chrome://browser/content/WebProgress.js:45

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Looks like |endLoading| is being called but |startLoading| was never called:
  https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/browser.js?r=ba2e9f9f2991#1316

This seems to be happening each time a new tab is opened. Perhaps it is just normal operation for |startLoading| not to be called when a new tab is created?

Comment 3

[Matt Brubeck (:mbrubeck)]

Yes, this has been around forever and I don't think it indicates a real problem.  I think we should just remove this check and not throw an exception.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Marking as a mentored bug, in case a new contributor wants to jump in before one of us happens to fix this :)

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

gbleaney has expressed interest in taking a stab at this issue.

gbleaney: As you mentioned, removing the check/exception from the |endLoading| function in browser.js is the way to start. Then verify that the function still works as expected... and, of course, that the error no longer appears in the error console :)

Comment 6

[Graham Bleaney [:gbleaney]]

Attachment: bug914278_removedCheckAndException.diff

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8335077 [details] [diff] [review]
bug914278_removedCheckAndException.diff

Review of attachment 8335077 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I applied the patch and tested on various websites (which I assume gbleaney did as well).

gbleaney - let me know if you need help landing this, or if you don't have commit access yet (in which case I'll land this for you)

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Setting checkin-needed: This can be landed along with other changes. No need to tax our builders by having them make builds with just this changeset.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1c86cdf8df86

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c86cdf8df86