Closed
Bug 914309
Opened 11 years ago
Closed 11 years ago
Cleanup rooting in Parser::objectLiteral() a bit
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
3.58 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #801732 -
Flags: review?(jorendorff)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 801732 [details] [diff] [review] Factor out fromMarkedLocation calls in Parser::objectLiteral() into a helper function; Review of attachment 801732 [details] [diff] [review]: ----------------------------------------------------------------- It's not a good idea to return the address of a local variable in C++.
Attachment #801732 -
Flags: review?(jorendorff) → review-
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 801732 [details] [diff] [review] Factor out fromMarkedLocation calls in Parser::objectLiteral() into a helper function; Review of attachment 801732 [details] [diff] [review]: ----------------------------------------------------------------- I am dumb. ::: js/src/frontend/Parser.cpp @@ +6520,5 @@ > +static JSAtom* > +DoubleToAtom(ExclusiveContext *cx, double value) > +{ > + Value tmp = DoubleValue(value); > + // This is safe because doubles can not be moved. SpiderMonkey house still micro-nit: Either put the comment first, or put a blank line before it.
Attachment #801732 -
Flags: review- → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/be1053dc223b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•