91438 - File bookmark folder into itself causes folder to be deleted

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Steps to reproduce:

1) Select a folder
2) Click "File Bookmark(s)..."
3) Select the same folder previously selected in the new dialog, and click OK

Actual results:
- folder disappears

Expected results:
- nothing, or something else, but certainly not the removal of the folder!

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to fix

Comment 2

[Blake Ross]

sr=blake
we could be smarter on the trunk, per discussion (but this is still good on the 
trunk).

Comment 3

[selmer (gone)]

Wait, didn't we fix this bug for the beta?  How did it come back?

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

I don't believe this was ever fixed. I don't think the code does any checking 
to see if it's not filing into itself. 

Comment 5

[selmer (gone)]

PDT+, taking a flyer.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, branch and trunk. 

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Actually fixed. 

Comment 8

[Claudius Gayle]

*** Bug 91317 has been marked as a duplicate of this bug. ***

Comment 9

[Claudius Gayle]

VERIFIED Fixed on 2001072006 branch builds adding vtrunk keyword

Comment 10

[Claudius Gayle]

VERIFIED Fixed with 2001070403 Trunk builds, marking as such.