If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

about: protocol should be case insensitive

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: Henrik Gemal, Assigned: Biesinger)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
currently the about: protocol is not case insensetive for what comes after the
":". It could be nice if it was.

Currently this works:
aBout:cache
ABOUT:cache
but this doesn't:
about:CAche
ABOUT:CACHE
build 20010718 on win2k
Summary: about: protocol should be case insensetive → about: protocol should be case insensitive
Created attachment 49132 [details] [diff] [review]
Converts what comes after about: to lowercase before looking for a module
(Reporter)

Updated

16 years ago
Keywords: patch, review
If all the current ones are lower case, I see no problem with this. Bbaetz?

Gerv
I thought I commented on this bug. Hmm.

The scheme is case insensitive by definition. url paths aren't, but we're not
using those.

some ns4 about urls are case sensitive, some aren't; I don't really have an
opinion. This would stop an about:mOzIlLa easter egg, though. I don't think
anyone was planning on that though :)
Assignee: pchen → neeti
Component: XP Apps → Networking
QA Contact: sairuh → benc

Comment 4

16 years ago
i don't have any problems with the patch (r/sr=darin)
Attachment #49132 - Flags: review+

Comment 5

16 years ago
r=pchen if you need it

Comment 6

16 years ago
Gagan, don't you own the about: protocol handler... Are you happy with this
proposed fix?
Assignee: neeti → gagan

Comment 7

16 years ago
yeah seems ok to me.

Comment 8

15 years ago
does this patch affect URLs that have case-sensitive parts?
Like this for example:

about:cache-entry?client=image&sb=0&key=http://www.edconrad.com/ebay/Smith1/MVC-004S.JPG
reassigning to me. I have completely forgotten about this, as I forgot to cc
mysef/assign to me when I created the patch. will checkin shortly
Assignee: gagan → cbiesinger
Alexey: no, such urls are not affected.

checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.