91439 - about: protocol should be case insensitive

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Henrik Gemal]

currently the about: protocol is not case insensetive for what comes after the
":". It could be nice if it was.

Currently this works:
aBout:cache
ABOUT:cache
but this doesn't:
about:CAche
ABOUT:CACHE
build 20010718 on win2k

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Converts what comes after about: to lowercase before looking for a module

Comment 2

[Gervase Markham [:gerv]]

If all the current ones are lower case, I see no problem with this. Bbaetz?

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

I thought I commented on this bug. Hmm.

The scheme is case insensitive by definition. url paths aren't, but we're not
using those.

some ns4 about urls are case sensitive, some aren't; I don't really have an
opinion. This would stop an about:mOzIlLa easter egg, though. I don't think
anyone was planning on that though :)

Comment 4

[Darin Fisher]

i don't have any problems with the patch (r/sr=darin)

Comment 5

[Paul Chen]

r=pchen if you need it

Comment 6

[Doug Turner (:dougt)]

Gagan, don't you own the about: protocol handler... Are you happy with this
proposed fix?

Comment 7

[Gagan]

yeah seems ok to me.

Comment 8

[Alexey Chernyak]

does this patch affect URLs that have case-sensitive parts?
Like this for example:

about:cache-entry?client=image&sb=0&key=http://www.edconrad.com/ebay/Smith1/MVC-004S.JPG

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

reassigning to me. I have completely forgotten about this, as I forgot to cc
mysef/assign to me when I created the patch. will checkin shortly

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Alexey: no, such urls are not affected.

checked in.