914399 - [B2G][Buri][Video][Vold] Video app continues playback after attaching to a PC/laptop

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[gbennett]

Attachment: VideoUSBplaybackLOG.txt

Description:
After plugging in the device via USB to PC/laptop during video playback, the video plays fully and a USB connection warning appears only after the video is complete. Via bug 866848: Plugging in USB to PC/laptop should immedately stop video playback and bring up the user friendly error message, "Video can not be watched while plugged in|Unplug the phone to watch videos."

Repro Steps:
1) Updated to Inari Build ID: 20130906040204
2) Open the "Video" app from the main screen
3) Tap on any video file
4) While the video is playing attach a USB cable.

Actual:
Video plays until completion then USB connected friendly error message is displayed.

Expected:
Video stops and USB connected friendly error message is displayed.

Environmental Variables
Device: Buri 1.2.0
Build ID: 20130906040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
Platform Version: 26.0a1

Notes:
Repro frequency: 6/6 100%
Test Suite Name: B2G Video
UCID: videoplay-000
Link to failed test case: https://moztrap.mozilla.org/manage/case/8792/
See attached: VideoUSBplaybackLOG.txt

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

I had checked the code and logcat. I found the behavior of AutoMounter is changed. So, the video app can't receive the shared event form DeviceStorage.

I/AutoMounter( 2279): UpdateState: umsAvail:1 umsEnabled:1 mode:1 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter( 2279): UpdateState: Volume sdcard is Mounted and inserted @ /mnt/sdcard gen 5 locked 0 sharing y
W/AutoMounter( 2279): The following files are open under '/mnt/sdcard'
W/AutoMounter( 2279):   PID: 3001 file: '/mnt/sdcard/DCIM/100MZLLA/VID_0001.3gp' app: 'Video' comm: 'Video' exe: '/system/b2g/plugin-container'
W/AutoMounter( 2279): UpdateState: Mounted volume sdcard has open files, not sharing


Once the playing is ended, we get:
I/AutoMounter( 2279): UpdateState: umsAvail:1 umsEnabled:1 mode:1 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter( 2279): UpdateState: Volume sdcard is Mounted and inserted @ /mnt/sdcard gen 5 locked 0 sharing y
I/AutoMounter( 2279): UpdateState: Unmounting sdcard
I/VolumeManager( 2279): Volume sdcard: changing state from Mounted to Unmounting (3 observers)
D/VoldCmdListener(  107): volume unmount sdcard force
D/Vold    (  107): Volume sdcard state changing 4 (Mounted) -> 5 (Unmounting)
I/VolumeManager( 2279): Volume sdcard: changing state from Unmounting to Idle (3 observers)
I/AutoMounter( 2279): UpdateState: umsAvail:1 umsEnabled:1 mode:1 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter( 2279): UpdateState: Volume sdcard is Idle and inserted
I/AutoMounter( 2279): UpdateState: Sharing sdcard
D/Vold    (  107): Volume sdcard state changing 5 (Unmounting) -> 1 (Idle-Unmounted)
I/VolumeManager( 2279): Volume sdcard: changing state from Idle to Shared (3 observers)
I/AutoMounter( 2279): UpdateState: umsAvail:1 umsEnabled:1 mode:1 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter( 2279): UpdateState: Volume sdcard is Shared and inserted
D/VoldCmdListener(  107): volume share sdcard ums
D/Vold    (  107): Volume sdcard state changing 1 (Idle-Unmounted) -> 7 (Shared-Unmounted)
I/AutoMounter( 2279): Changing mode from 'Enable' to 'DisableWhenUnplugged'
I/AutoMounter( 2279): UpdateState: umsAvail:1 umsEnabled:1 mode:2 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter( 2279): UpdateState: Volume sdcard is Shared and inserted

And at that moment, we get "shared" from DeviceStorage. That's the root cause of this bug. I had also checked the Gallery app and Music app. All of them are also affected.

I change the component to General and add Vold to title.

Comment 2

[Dominic Kuo [:dkuo]]

AutoMounter is changed in bug 876782 so the actual result is expected.

Comment 3

[gbennett]

Incorrect submitted first Repro Step: "1) Updated to Inari Build ID: 20130906040204"
Correct first Repro Step: "1) Updated to Buri Build ID: 20130906040204"

Sorry for any confusion.

Comment 4

[Dave Hylands [:dhylands]]

As far as I'm concerned, this is not a bug.

Bug 912609 is how I think this will be resolved (so when you try to share, you should get a dialog saying that you can't share because the Video app has a file open.

Comment 5

[Jason Smith [:jsmith]]

Invalid then per comment 4.