914410 - Disappearing mixed display icon - grey triangle on Ubuntu

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[Tanvi Vyas[:tanvi]]

Attachment: Disappearing_grey_triangle_ubuntu.jpg

1) Go to https://people.mozilla.com/~tvyas/mixeddisplay.html
2) You see a grey triangle as you should (from bug 865352) in the url bar.
3) Click on the grey triangle and the site identity box pops open, but the grey triangle is gone.
4) Click away to close the site identity box and the grey triangle is back.

I am not experiencing this on MacOSX.  Just ubuntu so far.  Any ideas why?

Mihai, can you test this on non-ubuntu linux?  Thanks!

Comment 1

[Mihai Morar, (:MihaiMorar)]

This is happening on Fedora 17 x64 too using Latest Nightly 26. Probably it's a general linux issue.

Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 BuildID: 20130911030258

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Tanvi, this bug is happening because the graphic being used for mixed display on Linux was incorrectly using the OSX version (2-state), when it needed to be the Windows version (3-state).

I have copied over the Windows version in this patch.

Comment 3

[Tanvi Vyas[:tanvi]]

Comment on attachment 804620 [details] [diff] [review]
Patch

(In reply to Jared Wein [:jaws] from comment #2)
> Created attachment 804620 [details] [diff] [review]
> Patch
> 
> Tanvi, this bug is happening because the graphic being used for mixed
> display on Linux was incorrectly using the OSX version (2-state), when it
> needed to be the Windows version (3-state).
> 
> I have copied over the Windows version in this patch.

Yes, you are right.  My mistake.  Thanks for catching this Jared!

Do you think I can land this today so that FF 26 goes to aurora with the right icon?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Tanvi Vyas [:tanvi] from comment #3)

> Do you think I can land this today so that FF 26 goes to aurora with the
> right icon?

Sure thing!

https://hg.mozilla.org/integration/fx-team/rev/3de581c2760b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3de581c2760b

Comment 6

[Mihai Morar, (:MihaiMorar)]

Verified as fixed on Latest Nightly 26 using Ubuntu 13.04 x86.