914457 - "ASSERTION: Non preserves axis aligned transform with clipped child should have forced intermediate surface"

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jesse Ruderman]

Attachment: testcase

With:
  user_pref("layers.force-active", true);

###!!! ASSERTION: Non preserves axis aligned transform with clipped child should have forced intermediate surface: 'is2D && matrix.PreservesAxisAlignedRectangles()', file gfx/layers/Layers.cpp, line 602

Comment 1

[Jesse Ruderman]

Attachment: stacks??

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

This patch corrects the issue.  I'll post this on MozReview once I've converted the testcase to a mochitest.

Comment 3

[:kip (Kearwood Gilbert)]

Attachment: MozReview Request: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region
- Layer::CalculateScissorRect no longer asserts when all children of a
  3d transformed layer have an empty visible region.

Comment 4

[:kip (Kearwood Gilbert)]

Attachment: MozReview Request: Bug 914457 - Part 2: Implement Crashtest

Bug 914457 - Part 2: Implement Crashtest
- Implemented a crashtest based on the testcase.

Comment 5

[:kip (Kearwood Gilbert)]

I have pushed to try to verify that the crashtest is working cross-platform:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63afef4e5810

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8658406 [details] [diff] [review]
Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

Marking earlier patch deprecated.  Please review the MozReview patch instead.

Comment 7

[:kip (Kearwood Gilbert)]

This bug is causing this assertion to spam excessively in WebVR use cases.

Comment 8

[:kip (Kearwood Gilbert)]

Comment on attachment 8659489 [details]
MozReview Request: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region
- Layer::CalculateScissorRect no longer asserts when all children of a
  3d transformed layer have an empty visible region.

Comment 9

[:kip (Kearwood Gilbert)]

Comment on attachment 8659490 [details]
MozReview Request: Bug 914457 - Part 2: Implement Crashtest

Bug 914457 - Part 2: Implement Crashtest
- Implemented a crashtest based on the testcase.

Comment 10

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8659489 [details]
MozReview Request: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

https://reviewboard.mozilla.org/r/18937/#review16839

Comment 11

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8659490 [details]
MozReview Request: Bug 914457 - Part 2: Implement Crashtest

https://reviewboard.mozilla.org/r/18939/#review16841

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8129b18d7398
https://hg.mozilla.org/integration/mozilla-inbound/rev/7367ddecab99

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8129b18d7398
https://hg.mozilla.org/mozilla-central/rev/7367ddecab99