Closed Bug 914457 Opened 6 years ago Closed 4 years ago

"ASSERTION: Non preserves axis aligned transform with clipped child should have forced intermediate surface"

Categories

(Core :: Graphics: Layers, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jruderman, Assigned: kip)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase, Whiteboard: [webvr] [vrm3])

Attachments

(4 files, 1 obsolete file)

Attached file testcase
With:
  user_pref("layers.force-active", true);

###!!! ASSERTION: Non preserves axis aligned transform with clipped child should have forced intermediate surface: 'is2D && matrix.PreservesAxisAlignedRectangles()', file gfx/layers/Layers.cpp, line 602
Attached file stacks??
Assignee: nobody → kgilbert
This patch corrects the issue.  I'll post this on MozReview once I've converted the testcase to a mochitest.
Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region
- Layer::CalculateScissorRect no longer asserts when all children of a
  3d transformed layer have an empty visible region.
Bug 914457 - Part 2: Implement Crashtest
- Implemented a crashtest based on the testcase.
I have pushed to try to verify that the crashtest is working cross-platform:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63afef4e5810
Comment on attachment 8658406 [details] [diff] [review]
Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

Marking earlier patch deprecated.  Please review the MozReview patch instead.
Attachment #8658406 - Attachment is obsolete: true
Whiteboard: [webvr] [vrm3]
This bug is causing this assertion to spam excessively in WebVR use cases.
Comment on attachment 8659489 [details]
MozReview Request: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region
- Layer::CalculateScissorRect no longer asserts when all children of a
  3d transformed layer have an empty visible region.
Attachment #8659489 - Flags: review?(matt.woodrow)
Comment on attachment 8659490 [details]
MozReview Request: Bug 914457 - Part 2: Implement Crashtest

Bug 914457 - Part 2: Implement Crashtest
- Implemented a crashtest based on the testcase.
Attachment #8659490 - Flags: review?(matt.woodrow)
Comment on attachment 8659489 [details]
MozReview Request: Bug 914457 - Part 1: Use an empty clip rect for layers with an empty visible region

https://reviewboard.mozilla.org/r/18937/#review16839
Attachment #8659489 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8659490 [details]
MozReview Request: Bug 914457 - Part 2: Implement Crashtest

https://reviewboard.mozilla.org/r/18939/#review16841
Attachment #8659490 - Flags: review?(matt.woodrow) → review+
You need to log in before you can comment on or make changes to this bug.