914528 - Mutt test failure "Unkown entity 'cmd.neverActivate.label'" in js/testElementsLib/testMenuList.js under ESR17

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Andrei Eftimie]

This failure is only affects ESR17, presumably we don't have the required dtd there.

Comment 1

[Andrei Eftimie]

Failing code was introduce as part of bug 871441

Given that this only affects ESR17, should we try to find a workaround for it?
Just skip the test for ESR17?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's nothing to worry too much about. We might want to have a gracefully fallback in place to make it work with ESR17.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Beside the dtd issue, Esr17 doesn't have the xul menulist like the other branches, in Plugins. Has only a "Disable" button. I wrapped the checks in an if block, so if the node exists we proceed, otherwise we skip that part of the code.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 802274 [details] [diff] [review]
patch v1

Review of attachment 802274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a good approach. Lets get the nit done and we should be able to land it.

::: mutt/mutt/tests/js/testElementsLib/testMenuList.js
@@ +87,5 @@
>               getAnonymousElementByAttribute(parent, "anonid", "state-menulist");
>    var menulist =  new elementslib.Elem(node);
>  
> +  // ESR17 does not have a xul menulist in Addons Manager - Plugins, neither dtds
> +  if (node) {

Please also move the menulist declaration inside the if condition. It doesn't seem to be used somewhere else.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v2

Correct. Moved that line inside the if block.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 802932 [details] [diff] [review]
patch v2

Review of attachment 802932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and I will get it landed. Please make sure to file a new bug, so we can have a local XUL testcase.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
https://github.com/mozilla/mozmill/compare/a1a917b0b67f...24d636bddb98 (master)
https://github.com/mozilla/mozmill/commit/63385049e4c06e4ffc261ec0d511e64beedac1e6 (hotfix-2.0)

Sadly I also landed an older version of the fix from bug 885221, which I backed out on master:
https://github.com/mozilla/mozmill/commit/6afb0ea70eb28d3ed17f2978313c6a5b45f60a0b