Shall we still maintain a redundant GraphicBufferAlloc.cpp in B2G(widget\gonk\libdisplay\GraphicBufferAlloc.cpp) ? GonkDisplayJB should be able to create GraphicBufferAlloc object by just including AOSP's <gui/GraphicBufferAlloc.h>. I guess it's the legacy from ICS that GraphicBufferAlloc was included in libsurfaceflinger.so, so B2G had to clone GraphicBufferAlloc independently. From JB, GraphicBufferAlloc was already moved to libgui.so. That would be easy for B2G to include.
Component: General → Widget: Gonk
Product: Boot2Gecko → Core
Doesn't that break the MR1 support you're working on?
(In reply to Michael Wu [:mwu] from comment #1) > Doesn't that break the MR1 support you're working on? Well, then it needs ANDROID_VERSION for separating MR1 and MR2. I will attach a patch here later.
Created attachment 806381 [details] [diff] [review] bug-914554-fix.patch
Assignee: nobody → vlin
Status: NEW → ASSIGNED
Attachment #806381 - Flags: review?(mwu)
https://hg.mozilla.org/integration/b2g-inbound/rev/354e832afdaf Please use your full name in your Hg committer information instead of just vlin. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.