Closed
Bug 914554
Opened 12 years ago
Closed 12 years ago
Remove a redundant GraphicBufferAlloc.cpp from B2G
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: vlin, Assigned: vlin)
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Shall we still maintain a redundant GraphicBufferAlloc.cpp in B2G(widget\gonk\libdisplay\GraphicBufferAlloc.cpp) ? GonkDisplayJB should be able to create GraphicBufferAlloc object by just including AOSP's <gui/GraphicBufferAlloc.h>.
I guess it's the legacy from ICS that GraphicBufferAlloc was included in libsurfaceflinger.so, so B2G had to clone GraphicBufferAlloc independently.
From JB, GraphicBufferAlloc was already moved to libgui.so. That would be easy for B2G to include.
|
Assignee | |
Updated•12 years ago
|
Flags: needinfo?(mwu)
|
|
Assignee | |
Updated•12 years ago
|
Component: General → Widget: Gonk
Product: Boot2Gecko → Core
|
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to Michael Wu [:mwu] from comment #1)
> Doesn't that break the MR1 support you're working on?
Well, then it needs ANDROID_VERSION for separating MR1 and MR2.
I will attach a patch here later.
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #806381 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/354e832afdaf
Please use your full name in your Hg committer information instead of just vlin. Thanks!
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•