[app manager] Services.settings not available

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: WebIDE
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: paul, Assigned: ochameau)

Tracking

Trunk
Firefox 26
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
On Unagi, for some reason, from the device actor, Services.settings is not available.

We then see many "n/a" all of the app manager.

This is what we should do:

1. figure out how Services.settings can be null while the phone looks to work well
2. fail properly in this case
3. if we get some "n/a", we should show something better (hide the header maybe, and probably rename "n/a" to "unknown").
(Reporter)

Updated

4 years ago
Component: Developer Tools → Developer Tools: App Manager
Summary: Services.settings not available → [app manager] Services.settings not available
(Reporter)

Comment 1

4 years ago
Apparently, this happens on the Keon as well. So it's not phone-specific. Probably a change on the gecko side.
It happens on my Keon all the time for me :)

Here is what I have on logcat.

I/GeckoDump( 2146):  -*- Shell.js: isDebugging=true
I/Gecko   ( 2146): console.error: 
E/GeckoConsole( 2146): Content JS ERROR at resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:817 in Actor<.writeError: Error: No settings service
I/Gecko   ( 2146):   Message: Error: No settings service
I/Gecko   ( 2146):   Stack:
I/Gecko   ( 2146):     DeviceActor<._getSetting@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/device.js:66
I/Gecko   ( 2146): DeviceActor<.getDescription<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/device.js:130
I/Gecko   ( 2146): actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
I/Gecko   ( 2146): DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1015
I/Gecko   ( 2146): @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:198
I/Gecko   ( 2146): @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:72
I/Gecko   ( 2146):
(Assignee)

Comment 3

4 years ago
Created attachment 803155 [details] [diff] [review]
Fix Services.settings being undefined r=paul
(Assignee)

Comment 4

4 years ago
Vivien, could you please flash your phone with this patch and tell me if this any better?
That's really weird. For me Services.settings shouldn't exists. Services.jsm doesn't define it!!
But it seems to be defined for me on unagi with gecko master...
So it is really hard to say if this patch is really going to fix this issue.
Flags: needinfo?(21)
(Assignee)

Comment 5

4 years ago
Comment on attachment 803155 [details] [diff] [review]
Fix Services.settings being undefined r=paul

Ok, I finally found where Services.settings is set:
http://mxr.mozilla.org/mozilla-central/source/b2g/components/UpdatePrompt.js#45

That's really awfull practice, and we were very lucky our usage of Services.settings was working in some cases...

That patch should fix this.
Attachment #803155 - Flags: review?(paul)
(Reporter)

Comment 6

4 years ago
Comment on attachment 803155 [details] [diff] [review]
Fix Services.settings being undefined r=paul

Good catch Alex. Thanks.
Attachment #803155 - Flags: review?(paul) → review+
(Reporter)

Comment 7

4 years ago
This might need to be checked in aurora (if it doesn't land in time).
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
This patch fixes the problem for me on my Nexus S.
https://hg.mozilla.org/integration/fx-team/rev/7b5b8819ac56
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7b5b8819ac56
Assignee: nobody → poirot.alex
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
(Assignee)

Updated

4 years ago
Blocks: 915258
Works for me now. Thanks :)
Flags: needinfo?(21)
(In reply to Alexandre Poirot (:ochameau) from comment #5)
> Comment on attachment 803155 [details] [diff] [review]
> Fix Services.settings being undefined r=paul
> 
> Ok, I finally found where Services.settings is set:
> http://mxr.mozilla.org/mozilla-central/source/b2g/components/UpdatePrompt.
> js#45
> 
> That's really awfull practice, and we were very lucky our usage of
> Services.settings was working in some cases...
> 
> That patch should fix this.

That's terrible... Can you please get a bug filed to remove all that?
Flags: needinfo?(poirot.alex)
(Assignee)

Comment 13

4 years ago
(In reply to :Ms2ger from comment #12)
> That's terrible... Can you please get a bug filed to remove all that?

Done. bug 923162.
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.