914594 - [app manager] Services.settings not available

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Paul Rouget [:paul]]

On Unagi, for some reason, from the device actor, Services.settings is not available.

We then see many "n/a" all of the app manager.

This is what we should do:

1. figure out how Services.settings can be null while the phone looks to work well
2. fail properly in this case
3. if we get some "n/a", we should show something better (hide the header maybe, and probably rename "n/a" to "unknown").

Comment 1

[Paul Rouget [:paul]]

Apparently, this happens on the Keon as well. So it's not phone-specific. Probably a change on the gecko side.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It happens on my Keon all the time for me :)

Here is what I have on logcat.

I/GeckoDump( 2146):  -*- Shell.js: isDebugging=true
I/Gecko   ( 2146): console.error: 
E/GeckoConsole( 2146): Content JS ERROR at resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:817 in Actor<.writeError: Error: No settings service
I/Gecko   ( 2146):   Message: Error: No settings service
I/Gecko   ( 2146):   Stack:
I/Gecko   ( 2146):     DeviceActor<._getSetting@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/device.js:66
I/Gecko   ( 2146): DeviceActor<.getDescription<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/device.js:130
I/Gecko   ( 2146): actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
I/Gecko   ( 2146): DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1015
I/Gecko   ( 2146): @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:198
I/Gecko   ( 2146): @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:72
I/Gecko   ( 2146):

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Fix Services.settings being undefined r=paul

Comment 4

[Alexandre Poirot [:ochameau]]

Vivien, could you please flash your phone with this patch and tell me if this any better?
That's really weird. For me Services.settings shouldn't exists. Services.jsm doesn't define it!!
But it seems to be defined for me on unagi with gecko master...
So it is really hard to say if this patch is really going to fix this issue.

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 803155 [details] [diff] [review]
Fix Services.settings being undefined r=paul

Ok, I finally found where Services.settings is set:
http://mxr.mozilla.org/mozilla-central/source/b2g/components/UpdatePrompt.js#45

That's really awfull practice, and we were very lucky our usage of Services.settings was working in some cases...

That patch should fix this.

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 803155 [details] [diff] [review]
Fix Services.settings being undefined r=paul

Good catch Alex. Thanks.

Comment 7

[Paul Rouget [:paul]]

This might need to be checked in aurora (if it doesn't land in time).

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

This patch fixes the problem for me on my Nexus S.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7b5b8819ac56

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b5b8819ac56

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Works for me now. Thanks :)

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Alexandre Poirot (:ochameau) from comment #5)
> Comment on attachment 803155 [details] [diff] [review]
> Fix Services.settings being undefined r=paul
> 
> Ok, I finally found where Services.settings is set:
> http://mxr.mozilla.org/mozilla-central/source/b2g/components/UpdatePrompt.
> js#45
> 
> That's really awfull practice, and we were very lucky our usage of
> Services.settings was working in some cases...
> 
> That patch should fix this.

That's terrible... Can you please get a bug filed to remove all that?

Comment 13

[Alexandre Poirot [:ochameau]]

(In reply to :Ms2ger from comment #12)
> That's terrible... Can you please get a bug filed to remove all that?

Done. bug 923162.