Status

Add-on SDK
General
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Needed for child-processes, sending in an initial patch (not tested x-platform yet)

Implementing chmod and chmodSync
Created attachment 802280 [details]
GH PR 1240
Blocks: 900288
Priority: -- → P3
(Assignee)

Updated

4 years ago
Attachment #802280 - Flags: review?(rFobic)
Comment on attachment 802280 [details]
GH PR 1240

r+ although I'd recommend porting tests from node to make sure it's fully compatible and we don't miss anything.
Attachment #802280 - Flags: review?(rFobic) → review+
Our tests currently are more robust than node's fs.chmod it seems:
https://github.com/joyent/node/blob/master/test/simple/test-fs-chmod.js

Also added ability to pass in strings as node does however

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d021b33146ee0d7ca51c7ec131a520017659b545
Bug 914606 Implement fs.chmod, fs.chmodSync

https://github.com/mozilla/addon-sdk/commit/0423a10003f5cefe29d2ec8c177f1ae05d85eace
Merge pull request #1240 from jsantell/fs-chown

Bug 914606 Implement fs.chmod, fs.chmodSync, r=@gozala
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Depends on: 923719
You need to log in before you can comment on or make changes to this bug.