914606 - Implement fs.chmod

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Needed for child-processes, sending in an initial patch (not tested x-platform yet)

Implementing chmod and chmodSync

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH PR 1240

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 802280 [details]
GH PR 1240

r+ although I'd recommend porting tests from node to make sure it's fully compatible and we don't miss anything.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Our tests currently are more robust than node's fs.chmod it seems:
https://github.com/joyent/node/blob/master/test/simple/test-fs-chmod.js

Also added ability to pass in strings as node does however

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d021b33146ee0d7ca51c7ec131a520017659b545
Bug 914606 Implement fs.chmod, fs.chmodSync

https://github.com/mozilla/addon-sdk/commit/0423a10003f5cefe29d2ec8c177f1ae05d85eace
Merge pull request #1240 from jsantell/fs-chown

Bug 914606 Implement fs.chmod, fs.chmodSync, r=@gozala