Closed
Bug 914639
Opened 12 years ago
Closed 12 years ago
X-Ray Goggles: metadata displayed as bare text in remix/<body>
Categories
(Webmaker Graveyard :: X-Ray Goggles, defect)
Webmaker Graveyard
X-Ray Goggles
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: info, Assigned: michiel)
References
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.1 (KHTML, like Gecko) Ubuntu/11.10 Chromium/21.0.1180.89 Chrome/21.0.1180.89 Safari/537.1
Steps to reproduce:
Remixed Buzzfeed.com website by replacing <img> and nested <img> fields on the page
To debug the problem I attempted to use a different Mozilla persona log in (stephenjfortune, email:stephen.j.fortune@gmail.com) . I remixed a successful Goggle's remoix, again by simply opening the goggles and pressing P to publish (see here) http://stephenjfortune.makes.org/goggles/stephenjfortunes-remix-of-real-women-of-canada-2
Actual results:
When pressed P to publish and obtained URL there was bare text HTML data displayed where it should have displayed "this page was made with X Ray Goggles ... etc"
You can see the result here http://stephenfortune.makes.org/goggles/stephenfortunes-remix-of-buzzfeed-2
I repeated the remix attempt but this time not changing any images in case it was the GIFs that were causing the problem.
Same result http://stephenfortune.makes.org/goggles/stephenfortunes-remix-of-buzzfeed-3
The text displayed is specific to each site. On a second webmaker account I created I attempted remixing sites other than buzzfeed. The same result was returned.
When remixing a successful Goggles project under my stephenjfortune persona, the same bare metadata was displayed at the top of the page. It was shorter in length but still present
Expected results:
I expected to get a remix like this, with no bare text http://p.webremixes.org/yozkyblt
Details of browsers and systems used while debugging on my side
for the new goggles we used the same bleaching policy that Thimble was using, which doesn't strip "bad" elements, but converts them to plain text. Turning stripping on for the goggles should be relatively easy to fix. Thanks for letting us know!
Assignee: nobody → pomax
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #802406 -
Flags: review?(kieran.sedgwick)
Attachment #802406 -
Flags: review?(kieran.sedgwick) → review?(ali)
|
||
Updated•12 years ago
|
Attachment #802406 -
Flags: review?(ali) → review+
landed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
\o/
Horrible bug, thank you!
|
||
Comment 7•12 years ago
|
||
Yay! :D
Awesome work guys, thank so so much for getting it resolved today!
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•