914693 - pushloghtml should show merges expanded by default rather than collapsed by default

Status: VERIFIED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[David Baron :dbaron:]

(This has bugged me since the since the Expand/Collapse feature was implemented, but I never got to filing a bug on it.  My memory is that other people had a similar negative reaction.)

Pushlogs collapse merge commits by default, e.g.:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startdate=2013-08-13+00%3A00%3A00&enddate=2013-08-15+16%3A00%3A00

This means that:
 (1) if you're skimming for certain words, it's easy to miss a merge commit

 (2) if you're skimming to judge size/complexity, it's easy to miss major sources of size/complexity

 (3) if you're using find-in-page to search for certain terms, it's easy to miss things

Doing *any* of these things requires searching for every [Expand] and clicking it.


I think merges should just be expanded by default.

Comment 1

[Benjamin Smedberg]

I think I agree, but in the meantime I have an "ExpandAll" bookmarklet which helps: 

javascript:(function(){$('.expand').filter(function(){return%20$(this).text()=="[Expand]";}).click()})()

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 3

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/hgcustom/hg_templates/rev/32eb0bbb3280

Comment 4

[Ed Morley [:emorley]]

Bah, missed that whilst the js toggles the caption, the initial string isn't populated via js, but from the localisation map:
https://hg.mozilla.org/hgcustom/hg_templates/file/32eb0bbb3280/gitweb_mozilla/map#l68

Comment 5

[Ed Morley [:emorley]]

Attachment: Update captions too

Also did s/N hidden changesets/N merge changesets/ since it doesn't make as much sense now expanded by default (even though it didn't toggle before).

Comment 6

[Ed Morley [:emorley]]

(And yey for having no easy way to tests these changes locally :-()

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 817904 [details] [diff] [review]
Update captions too

Review of attachment 817904 [details] [diff] [review]:
-----------------------------------------------------------------

It's not terribly hard to create a test repo with whatever commits you want and enable the pushlog extension on it, but yeah, it's also not trivial.

Comment 8

[Ed Morley [:emorley]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> It's not terribly hard to create a test repo with whatever commits you want
> and enable the pushlog extension on it, but yeah, it's also not trivial.

hgweb on Windows however... ;-)
(And yes I could just use one of my VMs, but then it starts to get disproportionate to the number of lines changed in the patch :-))

Comment 9

[Ed Morley [:emorley]]

And whilst a staging hgweb instance would be useful, I don't know how often it would get used (other than hg.m.o rollouts, but I presume we stand up specific instances for that).

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/hgcustom/hg_templates/rev/4002538e425d

Comment 11

[Ed Morley [:emorley]]

In production and working fine now :-)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Indeed. A very helpful change which saves us from clicking all around. Thanks a lot!

Comment 13

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/0f95cd46d2b4
https://hg.mozilla.org/hgcustom/version-control-tools/rev/766251b574e8