Closed Bug 914693 Opened 8 years ago Closed 7 years ago

pushloghtml should show merges expanded by default rather than collapsed by default

Categories

(Developer Services :: Mercurial: Pushlog, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: emorley)

References

Details

Attachments

(2 files)

(This has bugged me since the since the Expand/Collapse feature was implemented, but I never got to filing a bug on it.  My memory is that other people had a similar negative reaction.)

Pushlogs collapse merge commits by default, e.g.:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startdate=2013-08-13+00%3A00%3A00&enddate=2013-08-15+16%3A00%3A00

This means that:
 (1) if you're skimming for certain words, it's easy to miss a merge commit

 (2) if you're skimming to judge size/complexity, it's easy to miss major sources of size/complexity

 (3) if you're using find-in-page to search for certain terms, it's easy to miss things

Doing *any* of these things requires searching for every [Expand] and clicking it.


I think merges should just be expanded by default.
I think I agree, but in the meantime I have an "ExpandAll" bookmarklet which helps: 

javascript:(function(){$('.expand').filter(function(){return%20$(this).text()=="[Expand]";}).click()})()
Attached patch Patch v1Splinter Review
Attachment #803375 - Flags: review?(ted)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #803375 - Flags: review?(ted) → review+
Thank you :-)

https://hg.mozilla.org/hgcustom/hg_templates/rev/32eb0bbb3280
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 915633
Bah, missed that whilst the js toggles the caption, the initial string isn't populated via js, but from the localisation map:
https://hg.mozilla.org/hgcustom/hg_templates/file/32eb0bbb3280/gitweb_mozilla/map#l68
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Also did s/N hidden changesets/N merge changesets/ since it doesn't make as much sense now expanded by default (even though it didn't toggle before).
Attachment #817904 - Flags: review?(ted)
(And yey for having no easy way to tests these changes locally :-()
Comment on attachment 817904 [details] [diff] [review]
Update captions too

Review of attachment 817904 [details] [diff] [review]:
-----------------------------------------------------------------

It's not terribly hard to create a test repo with whatever commits you want and enable the pushlog extension on it, but yeah, it's also not trivial.
Attachment #817904 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> It's not terribly hard to create a test repo with whatever commits you want
> and enable the pushlog extension on it, but yeah, it's also not trivial.

hgweb on Windows however... ;-)
(And yes I could just use one of my VMs, but then it starts to get disproportionate to the number of lines changed in the patch :-))
And whilst a staging hgweb instance would be useful, I don't know how often it would get used (other than hg.m.o rollouts, but I presume we stand up specific instances for that).
In production and working fine now :-)
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Indeed. A very helpful change which saves us from clicking all around. Thanks a lot!
Status: RESOLVED → VERIFIED
Product: Webtools → Developer Services
You need to log in before you can comment on or make changes to this bug.