914760 - AndroidBridge::HandleGeckoMessage and friends log too much

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Richard Newman [:rnewman]]

There's a whole bunch of trace-level logging (e.g., function entry and exit) that's spewing at INFO.


void
AndroidBridge::HandleGeckoMessage(const nsAString &aMessage, nsAString &aRet)
{
    ALOG_BRIDGE("%s", __PRETTY_FUNCTION__);

    JNIEnv *env = GetJNIEnv();
    if (!env)
        return;

    AutoLocalJNIFrame jniFrame(env);
    jstring returnMessage = HandleGeckoMessageWrapper(aMessage);

    if (!returnMessage)
        return;

    nsJNIString jniStr(returnMessage, env);
    aRet.Assign(jniStr);
    ALOG_BRIDGE("leaving %s", __PRETTY_FUNCTION__);
}

That leads to this:

09-06 15:56:25.271 I/Gecko   (18837): AndroidBridge::GetStaticStringField RELEASE
09-06 15:56:25.271 I/Gecko   (18837): AndroidBridge::GetStaticStringField RELEASE
09-06 15:56:25.435 I/Gecko   (18837): AndroidBridge::GetStaticStringField RELEASE
09-06 15:56:34.553 I/Gecko   (18837): AndroidBridge::GetStaticStringField MODEL
09-06 15:56:34.553 I/Gecko   (18837): AndroidBridge::GetStaticStringField MANUFACTURER
09-06 15:56:34.553 I/Gecko   (18837): AndroidBridge::GetStaticStringField RELEASE
09-06 15:56:34.553 I/Gecko   (18837): AndroidBridge::GetStaticIntField SDK_INT
09-06 15:56:34.553 I/Gecko   (18837): AndroidBridge::GetStaticStringField HARDWARE
09-06 15:56:34.560 I/Gecko   (18837): AndroidBridge::EnableNetworkNotifications
09-06 15:56:34.849 I/Gecko   (18837): nsWindow[0x71ee4000]::Create 0x0 [0 0 1 1]
09-06 15:56:34.857 I/Gecko   (18837): nsWindow[0x71ee7000]::Create 0x0 [0 0 0 0]
09-06 15:56:34.857 I/Gecko   (18837): nsWindow[0x71ee7000]::Show 0
09-06 15:56:34.928 I/Gecko   (18837): nsWindow[0x71ee7000]::Resize [0.000000 0.000000 0.000000 0.000000] (repaint 0)
09-06 15:56:35.021 I/Gecko   (18837): nsWindow[0x71bec000]::Create 0x0 [0 0 0 0]
09-06 15:56:35.021 I/Gecko   (18837): nsWindow[0x71bec000]::Show 0
09-06 15:56:35.099 I/Gecko   (18837): nsWindow[0x71e97000]::Create 0x0 [0 0 0 0]
09-06 15:56:35.099 I/Gecko   (18837): nsWindow[0x71e97000]::Show 0
09-06 15:56:35.115 I/Gecko   (18837): WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /home/mcomella/dev/moz/layout/style/Loader.cpp, line 1995
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetScreenDepth
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetGfxInfoData
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticStringField MODEL
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticStringField PRODUCT
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticStringField MANUFACTURER
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticIntField SDK_INT
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticStringField HARDWARE
09-06 15:56:35.365 I/Gecko   (18837): AndroidBridge::GetStaticStringField RELEASE
09-06 15:56:41.248 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:41.248 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:41.381 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:41.389 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:41.959 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:41.959 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:42.178 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.092 I/Gecko   (18837): WARNING: NS_ENSURE_TRUE(mMutable) failed: file /home/mcomella/dev/moz/netwerk/base/src/nsSimpleURI.cpp, line 266
09-06 15:56:45.107 I/Gecko   (18837): WARNING: NS_ENSURE_TRUE(mMutable) failed: file /home/mcomella/dev/moz/netwerk/base/src/nsSimpleURI.cpp, line 266
09-06 15:56:45.326 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.326 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.342 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.342 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.349 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.349 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.357 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.357 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.357 I/GeckoToolbar(18837): zerdatime 22233468 - Throbber stop
09-06 15:56:45.365 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.373 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.373 I/GeckoToolbar(18837): zerdatime 22233480 - Throbber start
09-06 15:56:45.389 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.389 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.404 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.404 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.412 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.412 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.724 I/Gecko   (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
09-06 15:56:45.724 I/Gecko   (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)

Comment 1

[Chris Kitching [:ckitching]]

Ah yes. This is going to get deeply annoying, what with HandleGeckoMessage being called as often as it is. Some such entry/exit methods existed on the non-generated versions of some of these. Should I delete all such messages anyway?

Comment 2

[Richard Newman [:rnewman]]

Delete, log at verbose/trace, or #define - off.

Comment 3

[Chris Kitching [:ckitching]]

Attachment: Remove the extra debugging lines.

Righto. Here's a pair of patches to sort it out. This one deletes the extra debugging lines...

Comment 4

[Chris Kitching [:ckitching]]

Attachment: Don't generate extra debugging lines.

... And this patch stops the generator from making them in the first place.

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 802617 [details] [diff] [review]
Remove the extra debugging lines.

Review of attachment 802617 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5b6750d49d
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f571670f864

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f5b6750d49d
https://hg.mozilla.org/mozilla-central/rev/4f571670f864