Closed
Bug 914760
Opened 11 years ago
Closed 11 years ago
AndroidBridge::HandleGeckoMessage and friends log too much
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: rnewman, Assigned: ckitching)
Details
Attachments
(2 files)
69.15 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
4.00 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
There's a whole bunch of trace-level logging (e.g., function entry and exit) that's spewing at INFO. void AndroidBridge::HandleGeckoMessage(const nsAString &aMessage, nsAString &aRet) { ALOG_BRIDGE("%s", __PRETTY_FUNCTION__); JNIEnv *env = GetJNIEnv(); if (!env) return; AutoLocalJNIFrame jniFrame(env); jstring returnMessage = HandleGeckoMessageWrapper(aMessage); if (!returnMessage) return; nsJNIString jniStr(returnMessage, env); aRet.Assign(jniStr); ALOG_BRIDGE("leaving %s", __PRETTY_FUNCTION__); } That leads to this: 09-06 15:56:25.271 I/Gecko (18837): AndroidBridge::GetStaticStringField RELEASE 09-06 15:56:25.271 I/Gecko (18837): AndroidBridge::GetStaticStringField RELEASE 09-06 15:56:25.435 I/Gecko (18837): AndroidBridge::GetStaticStringField RELEASE 09-06 15:56:34.553 I/Gecko (18837): AndroidBridge::GetStaticStringField MODEL 09-06 15:56:34.553 I/Gecko (18837): AndroidBridge::GetStaticStringField MANUFACTURER 09-06 15:56:34.553 I/Gecko (18837): AndroidBridge::GetStaticStringField RELEASE 09-06 15:56:34.553 I/Gecko (18837): AndroidBridge::GetStaticIntField SDK_INT 09-06 15:56:34.553 I/Gecko (18837): AndroidBridge::GetStaticStringField HARDWARE 09-06 15:56:34.560 I/Gecko (18837): AndroidBridge::EnableNetworkNotifications 09-06 15:56:34.849 I/Gecko (18837): nsWindow[0x71ee4000]::Create 0x0 [0 0 1 1] 09-06 15:56:34.857 I/Gecko (18837): nsWindow[0x71ee7000]::Create 0x0 [0 0 0 0] 09-06 15:56:34.857 I/Gecko (18837): nsWindow[0x71ee7000]::Show 0 09-06 15:56:34.928 I/Gecko (18837): nsWindow[0x71ee7000]::Resize [0.000000 0.000000 0.000000 0.000000] (repaint 0) 09-06 15:56:35.021 I/Gecko (18837): nsWindow[0x71bec000]::Create 0x0 [0 0 0 0] 09-06 15:56:35.021 I/Gecko (18837): nsWindow[0x71bec000]::Show 0 09-06 15:56:35.099 I/Gecko (18837): nsWindow[0x71e97000]::Create 0x0 [0 0 0 0] 09-06 15:56:35.099 I/Gecko (18837): nsWindow[0x71e97000]::Show 0 09-06 15:56:35.115 I/Gecko (18837): WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /home/mcomella/dev/moz/layout/style/Loader.cpp, line 1995 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetScreenDepth 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetGfxInfoData 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticStringField MODEL 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticStringField PRODUCT 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticStringField MANUFACTURER 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticIntField SDK_INT 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticStringField HARDWARE 09-06 15:56:35.365 I/Gecko (18837): AndroidBridge::GetStaticStringField RELEASE 09-06 15:56:41.248 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:41.248 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:41.381 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:41.389 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:41.959 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:41.959 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:42.178 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.092 I/Gecko (18837): WARNING: NS_ENSURE_TRUE(mMutable) failed: file /home/mcomella/dev/moz/netwerk/base/src/nsSimpleURI.cpp, line 266 09-06 15:56:45.107 I/Gecko (18837): WARNING: NS_ENSURE_TRUE(mMutable) failed: file /home/mcomella/dev/moz/netwerk/base/src/nsSimpleURI.cpp, line 266 09-06 15:56:45.326 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.326 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.342 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.342 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.349 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.349 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.357 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.357 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.357 I/GeckoToolbar(18837): zerdatime 22233468 - Throbber stop 09-06 15:56:45.365 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.373 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.373 I/GeckoToolbar(18837): zerdatime 22233480 - Throbber start 09-06 15:56:45.389 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.389 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.404 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.404 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.412 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.412 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.724 I/Gecko (18837): void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&) 09-06 15:56:45.724 I/Gecko (18837): leaving void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
Assignee | ||
Comment 1•11 years ago
|
||
Ah yes. This is going to get deeply annoying, what with HandleGeckoMessage being called as often as it is. Some such entry/exit methods existed on the non-generated versions of some of these. Should I delete all such messages anyway?
Assignee: nobody → ckitching
Reporter | ||
Comment 2•11 years ago
|
||
Delete, log at verbose/trace, or #define - off.
Assignee | ||
Comment 3•11 years ago
|
||
Righto. Here's a pair of patches to sort it out. This one deletes the extra debugging lines...
Attachment #802617 -
Flags: review?(rnewman)
Assignee | ||
Comment 4•11 years ago
|
||
... And this patch stops the generator from making them in the first place.
Attachment #802618 -
Flags: review?(rnewman)
Reporter | ||
Updated•11 years ago
|
Attachment #802618 -
Flags: review?(rnewman) → review+
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 802617 [details] [diff] [review] Remove the extra debugging lines. Review of attachment 802617 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #802617 -
Flags: review?(rnewman) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5b6750d49d https://hg.mozilla.org/integration/mozilla-inbound/rev/4f571670f864
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f5b6750d49d https://hg.mozilla.org/mozilla-central/rev/4f571670f864
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•