914796 - make subprocess async in slaveapi

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I noticed some surprising delays in requests while testing some stuff in slaveapi today. After some googling, it looks like subprocess isn't async'ed by the version of Gevent that we use. Looks like https://github.com/bombela/gevent_subprocess might help with that.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: make subprocess actually async

Turns out that subprocess were indeed not async. With this patch applied the same set of requests all return immediately - even though slaveapi is running subprocess (in the background now, yay!). This also seems to fix bug 913615 because DNS requests don't get shoved off to the side while a subprocess is running.

Mostly I'm relying on the gevent_subprocess module here, but I had to do the patching of subprocess on my own because it doesn't provide a helper to do so.