Closed
Bug 914806
Opened 11 years ago
Closed 11 years ago
Remove the "allowedAreas" code in CustomizableUI and CustomizableWidgets
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: jaws, Assigned: aks)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][mentor=jaws][lang=js][Australis:M9][Australis:P5])
Attachments
(1 file)
|
8.32 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
The allowedArea code in CustomizableUI.jsm and CustomizableWidgets.jsm is unused and thus dead code. We don't have plans to add the ability to make widgets only allowed in specific areas, so this code can be removed now. To work on this bug, you'll need to clone the HG repo located at https://hg.mozilla.org/projects/ux/. The files in question are located at /browser/components/customizableui/src/CustomizableUI.jsm and /browser/components/customizableui/src/CustomizableWidgets.jsm
|
||
Comment 1•11 years ago
|
||
want to work on this one.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → nautigitakshay
Status: NEW → ASSIGNED
|
|
||
Comment 2•11 years ago
|
||
downloaded the code ... this is going to be my first bug sir. how do i approch this one?
|
|
Reporter | |
Comment 3•11 years ago
|
||
You should join the #introduction channel on ircs://irc.mozilla.org and someone can help you walk through getting your first build up and running.
|
|
||
Comment 4•11 years ago
|
||
i am still very interested in solving this bug , only thing i have university exams going on so give me a week before you think of assiging this to someone else.Thanks in advance.
|
Assignee | |
Comment 5•11 years ago
|
||
Removed all the "allowedAreas" code :)
Attachment #809170 -
Flags: review?(jaws)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 809170 [details] [diff] [review] 914806.patch Review of attachment 809170 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! I pushed it to the UX repository, thanks! https://hg.mozilla.org/projects/ux/rev/017f628d07af
Attachment #809170 -
Flags: review?(jaws) → review+
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [good first bug][mentor=jaws][lang=js][Australis:M?][Australis:P5] → [good first bug][mentor=jaws][lang=js][Australis:M9][Australis:P5][fixed-in-ux]
|
|
Assignee | |
Comment 7•11 years ago
|
||
Awesome !
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/017f628d07af
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jaws][lang=js][Australis:M9][Australis:P5][fixed-in-ux] → [good first bug][mentor=jaws][lang=js][Australis:M9][Australis:P5]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Assignee: nautigitakshay → aksht.kedia
You need to log in
before you can comment on or make changes to this bug.
Description
•