914914 - '-p all' on try gives you Win64 opt and debug builds (try is getting behind on windows builds)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Regression from bug 893139.
 
win64 has try_by_default set to false, win64-debug doesn't. Both get builds with a '-p all' try chooser line. Taken with re-enabling b2g desktop for win32, we have many more jobs to do on try and are experiencing backlogs and delays.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

https://tbpl.mozilla.org/?tree=Try&jobname=WINNT&fromchange=6e6bb91a91db&tochange=f7bb5c8f0683 for confirmation of this.

Comment 2

[Steve Fink [:sfink] [:s:]]

I won't have time to look at this in detail until this evening, but from a quick glance at the code, I think this may be hitting a case that I was crossing my fingers and hoping nobody would run into. Having a platform with different defaultness settings for opt and debug is problematic due to the way platform and sub-platforms (X and X-debug) are passed through.

I don't remember offhand what would be required to fix this, but it may require changing the way the scheduler communicates with the tryChooser (probably by making prettyNames use a dictionary of attributes instead of the awful string parsing hacks we rely on now.)

There may be an alternative nasty hack way of fixing it by renaming win64-debug to win64-debug-hack or something.

Comment 3

[Phil Ringnalda (:philor)]

Fortunately, we don't really need to fix it in trychooser at the moment, since the right fix for this case is to make win64-debug try_by_default: False.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buidlbot-configs] make debug try_by_default: False

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 802731 [details] [diff] [review]
[buidlbot-configs] make debug try_by_default: False

https://hg.mozilla.org/build/buildbot-configs/rev/54b09ca6e89e

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

In production.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Before deployment - https://tbpl.mozilla.org/?tree=Try&jobname=WINNT&rev=7aa707752360 - win32 + win64After deployment  - https://tbpl.mozilla.org/?tree=Try&jobname=WINNT&rev=d45acd4d3858 - only win32