Closed
Bug 914925
Opened 10 years ago
Closed 10 years ago
mach reftest --debugger doesn't work
Categories
(Testing :: Reftest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: heycam, Assigned: Ms2ger)
References
Details
Attachments
(1 file, 4 obsolete files)
7.54 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Same as bug 913173, but for reftest. master irk:/z/moz/central $ ./mach reftest --debugger=gdb 0:00.20 /usr/bin/make -C . -j8 -s -w reftest make: Entering directory `/z/moz/central/obj-mac-dbg' REFTEST INFO | runreftest.py | Running tests: start. INFO | automation.py | Launching: /usr/bin/gdb -q --args /z/moz/central/obj-mac-dbg/dist/NightlyDebug.app/Contents/MacOS/firefox-bin -foreground -no-remote -profile /var/folders/04/rtvfhstx5c1_y4sv_179m40c0000gn/T/tmpFHBM2J.mozrunner/ -reftest /z/moz/central/layout/reftests/reftest.list INFO | automation.py | Application pid: 20356 TEST-INFO: Not logging stdout or stderr due to debugger connection Reading symbols for shared libraries ......... done (gdb) r Starting program: /z/moz/central/obj-mac-dbg/dist/NightlyDebug.app/Contents/MacOS/firefox-bin -foreground -no-remote -profile /var/folders/04/rtvfhstx5c1_y4sv_179m40c0000gn/T/tmpFHBM2J.mozrunner/ -reftest /z/moz/central/layout/reftests/reftest.list ... Program exited with code 06. (gdb)
Reporter | ||
Comment 1•10 years ago
|
||
I tried sticking in something like bug 913173 comment 11 in runreftest.py's buildBrowserEnv but this didn't have any effect.
Comment 2•10 years ago
|
||
I got motivated and did a Mac build and could reproduce the problem (in both reftest and mochitest). This patch fixes the problem.
Updated•10 years ago
|
Assignee: nobody → ted
Updated•10 years ago
|
Attachment #803185 -
Flags: review?(jmaher)
Comment 3•10 years ago
|
||
Comment on attachment 803185 [details] [diff] [review] fix --debugger for reftest/mochitest on OS X Review of attachment 803185 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/tools/reftest/runreftest.py @@ +107,5 @@ > ) > self.copyExtraFilesToProfile(options, profile) > return profile > > + def buildBrowserEnv(self, options, profileDir, debugger): why are you not setting this to a default value of False as you do in the mochitest runner?
Attachment #803185 -
Flags: review?(jmaher) → review+
Comment 4•10 years ago
|
||
I didn't think it was necessary since this was the only caller, but I forgot that runtestsremote calls this as well. I'll fix that, thanks!
Comment 5•10 years ago
|
||
Oh, actually, I guess nothing does call the reftest version, but I'll fix it just for sanity.
Comment 6•10 years ago
|
||
Updated•10 years ago
|
Attachment #803185 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #803816 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9157ea42ff41
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
Backed out for remote test bustage. https://hg.mozilla.org/integration/fx-team/rev/a23d608fb893
Whiteboard: [fixed-in-fx-team]
Comment 10•10 years ago
|
||
This patch doesn't seem to fix the problem for me, still can't debug reftests.
Comment 11•10 years ago
|
||
You need to apply the patch then rebuild the build/ directory to get automation.py updated. I tested on my Mac and it worked, so I suspect it's just horrible preprocessed Python nonsense.
Comment 12•10 years ago
|
||
The patch seems to have rotted, and the naïve manual application of the reject files doesn't seem to produce a viable environment.
Comment 13•10 years ago
|
||
Rebased to work on top of the Mochitest refactor.
Updated•10 years ago
|
Attachment #803816 -
Attachment is obsolete: true
Comment 14•10 years ago
|
||
I still need to manually apply this patch to basically every repo I work in, FWIW.
Comment 15•10 years ago
|
||
At the summit, Ted promised to land something to make mochitests work with a debugger again.
Flags: needinfo?(ted)
Comment 16•10 years ago
|
||
This patch only touches Mochitest. This should be simpler to land.
Updated•10 years ago
|
Attachment #809201 -
Attachment is obsolete: true
Comment 17•10 years ago
|
||
*sigh*, that still broke Android tests: https://tbpl.mozilla.org/?tree=Try&rev=2cd6ba574f2e
Flags: needinfo?(ted)
Comment 18•10 years ago
|
||
Can we get some traction here? Manually shuffling this patch around in local trees is a pain (especially because it borks android try pushes), but more importantly, this is mysteriously breaks the experience of any newcomer dev who doesn't know about the workaround.
Flags: needinfo?(ted)
Assignee | ||
Comment 20•10 years ago
|
||
Attachment #821204 -
Attachment is obsolete: true
Attachment #8334493 -
Flags: review?(jmaher)
Assignee | ||
Comment 21•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d8a3663659bb
Comment 22•10 years ago
|
||
Comment on attachment 8334493 [details] [diff] [review] Patch v2 Review of attachment 8334493 [details] [diff] [review]: ----------------------------------------------------------------- this looks to be the right patch.
Attachment #8334493 -
Flags: review?(jmaher) → review+
![]() |
||
Comment 23•10 years ago
|
||
Ms2ger, thank you!
Assignee | ||
Comment 24•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c31c75b81ea
Flags: needinfo?(ted)
Comment 25•10 years ago
|
||
Ms2ger, you are a hero.
Comment 26•10 years ago
|
||
Thanks for that, I owe you one.
Comment 27•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c31c75b81ea
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Flags: needinfo?(ted)
You need to log in
before you can comment on or make changes to this bug.
Description
•