914931 - Test packaged apps update

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: test_packaged_apps_update

This test is a simple test, quite similar to the hosted and cached app tests.

Comment 1

[[:fabrice] Fabrice Desré]

We already have some coming in bug 900553.

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Fabrice Desré [:fabrice] from comment #1)
> We already have some coming in bug 900553.

Yes, I've seen them, this one is a bit different because it actually loads the application in an iframe.

Comment 3

[[:fabrice] Fabrice Desré]

Sure, but that's not a good reason to have duplicate tests. Improve the existing ones if you wish, but duplication is not great.

Comment 4

[Marco Castelluccio [:marco]]

Oh, yes, sure, I'll build on top of the test in bug 900553 when it will land! I just wanted to make sure that this test was actually useful, to avoid wasting time if it wasn't.

I've made this one a chrome mochitest because otherwise I couldn't load a app:// url in the iframe (because of the Ci.nsIProtocolHandler.URI_DANGEROUS_TO_LOAD flag, IIRC). Do you know of any workaround so that I can make it a plain mochitest?

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Add simple test to test_packaged_app_update

This adds a small test to check that checkForUpdate doesn't find updates right after an application is installed and that mozIDOMApplication::download() doesn't download anything if no update is available.

The test that checks the package contents by loading the app in an iframe isn't yet present in this patch.
It needs to be in a chrome mochitest, do you want me to convert test_packaged_app_update.html to a chrome mochitest or do you prefer me to create a new test for that? (unless you know a workaround to allow the app:// protocol to be used in an iframe in a plain mochitest)

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 806976 [details] [diff] [review]
Add simple test to test_packaged_app_update

Review of attachment 806976 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but please send to try before landing

::: dom/apps/tests/test_packaged_app_update.html
@@ +29,5 @@
>  var miniManifestURL;
>  
>  SimpleTest.waitForExplicitFinish();
>  
> +function checkForUpdate(aExpected, aOnSuccess, aOnApplied, aOnDownloadError, aLaunchDownload, aOnRequestError) {

nit: is this < 80 chars?

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Patch

https://tbpl.mozilla.org/?tree=Try&rev=211e3df88180

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/83f7bb56300b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/83f7bb56300b