Closed
Bug 914980
Opened 11 years ago
Closed 11 years ago
Fix debug log level to not depend on self.options.test
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: me)
References
Details
(Whiteboard: [mentor=whimboo][lang=py][good first bug][mozmill-1.5.23])
Attachments
(1 file)
|
897 bytes,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
As found by Vlad on bug 871628 the code in Mozmill 1.5 to let us use debug output via the API is busted because it depends on self.options.test which is not set under this condition. Also it doesn't make sense to have that check there. Lets get it removed. Vlad, are you interested to fix it?
|
Assignee | |
Comment 1•11 years ago
|
||
Sure. Do you want the patch as a github pull request, or as a diff?
|
Reporter | |
Comment 2•11 years ago
|
||
Great. So for Mozmill we work with patches attached to Bugzilla. You can export it by running 'git format-patch HEAD^'. Thanks!
Assignee: nobody → me
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•11 years ago
|
||
Here you go, Henrik. Let me know if you need anything else.
Attachment #803590 -
Flags: review?(hskupin)
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 803590 [details] [diff] [review] 0001-Bug-914980-Fix-debug-log-level-to-not-depend-on-self.patch Review of attachment 803590 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine and fixes the debug output for -m (manifest) like testruns. Thanks a lot!
Attachment #803590 -
Flags: review?(hskupin) → review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
Landed on hotfix-1.5: https://github.com/mozilla/mozmill/commit/e6f998bfb22098dd6472d21f81d1ffbb6338cea6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=whimboo][lang=py][good first bug][mozmill-1.5.23?] → [mentor=whimboo][lang=py][good first bug][mozmill-1.5.23]
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•