914980 - Fix debug log level to not depend on self.options.test

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

As found by Vlad on bug 871628 the code in Mozmill 1.5 to let us use debug output via the API is busted because it depends on self.options.test which is not set under this condition. Also it doesn't make sense to have that check there. Lets get it removed.

Vlad, are you interested to fix it?

Comment 1

[Vlad Dolezal]

Sure. Do you want the patch as a github pull request, or as a diff?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Great. So for Mozmill we work with patches attached to Bugzilla. You can export it by running 'git format-patch HEAD^'. Thanks!

Comment 3

[Vlad Dolezal]

Attachment: 0001-Bug-914980-Fix-debug-log-level-to-not-depend-on-self.patch

Here you go, Henrik. Let me know if you need anything else.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Comment on attachment 803590 [details] [diff] [review]
0001-Bug-914980-Fix-debug-log-level-to-not-depend-on-self.patch

Review of attachment 803590 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine and fixes the debug output for -m (manifest) like testruns. Thanks a lot!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Landed on hotfix-1.5:
https://github.com/mozilla/mozmill/commit/e6f998bfb22098dd6472d21f81d1ffbb6338cea6