Closed
Bug 914996
Opened 11 years ago
Closed 11 years ago
Trying to show a notification with a valid icon URL fails to show the icon in the notification
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:koi+)
VERIFIED
WORKSFORME
blocking-b2g | koi+ |
People
(Reporter: jsmith, Assigned: qdot)
References
Details
(Whiteboard: [systemsfe] burirun1)
Attachments
(1 file)
1.87 KB,
text/plain
|
Details |
Build: Master 9/11/2013 Device: Unagi STR 1. Go to http://mozilla.github.io/qa-testcase-data/webapi/notifications/index.html 2. Install the hosted app with permissions 3. Launch the app 4. Try to show a notification with a valid icon URL provided (e.g. http://mozilla.github.io/qa-testcase-data/webapi/notifications/qalogo.png) Expected The notification should be shown in the status bar with the icon specified if it exists. Actual No icon is seen with the notification.
Reporter | ||
Updated•11 years ago
|
Blocks: b2g-notifications
blocking-b2g: --- → koi?
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Should be a dup of 901214 and will be fixed with the patch in bug 904298
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Gregor Wagner [:gwagner] from comment #2) > Should be a dup of 901214 and will be fixed with the patch in bug 904298 Are you sure? bug 901214 deals with permissions, where this just relates to getting the icon from a HTTP URL within an app.
Comment 4•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #3) > (In reply to Gregor Wagner [:gwagner] from comment #2) > > Should be a dup of 901214 and will be fixed with the patch in bug 904298 > > Are you sure? bug 901214 deals with permissions, where this just relates to > getting the icon from a HTTP URL within an app. Oh ignore me I mixed up some bugs. Somehow I saw a logcat that showed the process got killed because of missing 'desktop-notification' permission.
Reporter | ||
Updated•11 years ago
|
Whiteboard: [systems-fe]
Reporter | ||
Updated•11 years ago
|
Whiteboard: [systems-fe] → [systemsfe]
Reporter | ||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Updated•11 years ago
|
Whiteboard: [systemsfe] → [systemsfe] burirun1
Comment 5•11 years ago
|
||
Peter Dolanjski changed story state to started in Pivotal Tracker
Assignee | ||
Comment 6•11 years ago
|
||
When firing through new API, we send a system message with an imageURL property, not icon as expected.
Assignee: nobody → kyle
Assignee | ||
Comment 7•11 years ago
|
||
Hey peter, should we show the app icon of the notifying app if there isn't an icon specified for the notification?
Flags: needinfo?(pdolanjski)
Assignee | ||
Comment 8•11 years ago
|
||
Ok, I was wrong on comment 6. We convert imageURL to icon in shell.js, so icons work fine in B2G Desktop 2013-09-19. The problem comes in the test app listed in comment 0. The property block sent as part of the new Notification() call specifies iconURL, not icon, as is laid out in the spec. This is why icons don't work in the test app. Marking WFM. Will break out new bugs for writing tests for icons for notifications and updating the very very wrong uitests, as well as possibly defaulting to app icons depending on what pdol says.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Comment 9•11 years ago
|
||
Kyle Machulis changed story state to accepted in Pivotal Tracker
Comment 10•11 years ago
|
||
Kyle Machulis changed story state to accepted in Pivotal Tracker
Comment 11•11 years ago
|
||
Kyle Machulis changed story state to accepted in Pivotal Tracker
Reporter | ||
Comment 12•11 years ago
|
||
Yup. Confirmed this is a bug in my app - just patched and fixed it. Confirmed I'm seeing icons now.
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Flags: needinfo?(pdolanjski)
You need to log in
before you can comment on or make changes to this bug.
Description
•