remove quirk allowing {} around style attribute

RESOLVED FIXED in mozilla27

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {dev-doc-complete, site-compat})

Trunk
mozilla27
dev-doc-complete, site-compat
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2517 shows that other browsers (IE, blink, WebKit) no longer implement the quirk added in bug 99554 to allow {} around the style attribute.  We should remove this.

(Discussed in CSS meeting today, briefly.)
(Assignee)

Comment 1

4 years ago
Created attachment 802989 [details] [diff] [review]
Remove quirk allowing {} around style attribute.

The tests pass with the patch; without the patch
test_style_attribute_quirks.html fails 2 tests.
Attachment #802989 - Flags: review?(cam)
Comment on attachment 802989 [details] [diff] [review]
Remove quirk allowing {} around style attribute.

Review of attachment 802989 [details] [diff] [review]:
-----------------------------------------------------------------

(I guess it would have been simpler to write the test as a reftest, but either way.)
Attachment #802989 - Flags: review?(cam) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2a946c673af
Flags: in-testsuite+
(Assignee)

Comment 4

4 years ago
(In reply to Cameron McCormack (:heycam) from comment #2)
> (I guess it would have been simpler to write the test as a reftest, but
> either way.)

Script tests should be lower-overhead to run, though.
https://hg.mozilla.org/mozilla-central/rev/a2a946c673af
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Adding dev-doc-needed, I'm not sure this was previously documented, but if so we have to fix the documentation.
Keywords: dev-doc-needed

Comment 7

4 years ago
"In quirks mode, the CSS parser allows {} around the contents of style attributes (bug 99554)."
https://developer.mozilla.org/en-US/docs/Mozilla_Quirks_Mode_Behavior
I added a sentence "This behavior is being removed in Firefox 27, for interoperability.", plus a link to this bug, after the quote in Comment 7.  Feel free to edit/extend as appropriate.

Leaving dev-doc-needed in case there's anything else that needs updating.
Simon, what's the testing situation here?
Flags: needinfo?(zcorpan)

Comment 10

4 years ago
I've submitted http://hg.csswg.org/test/rev/0274e82f1553 (feel free to review so it can be moved to approved)
Flags: needinfo?(zcorpan)
https://developer.mozilla.org/en-US/Firefox/Releases/27/Site_Compatibility
Keywords: dev-doc-needed → dev-doc-complete, site-compat
You need to log in before you can comment on or make changes to this bug.