Closed
Bug 915053
Opened 11 years ago
Closed 11 years ago
remove quirk allowing {} around style attribute
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dbaron, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
4.97 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2517 shows that other browsers (IE, blink, WebKit) no longer implement the quirk added in bug 99554 to allow {} around the style attribute. We should remove this.
(Discussed in CSS meeting today, briefly.)
Assignee | ||
Comment 1•11 years ago
|
||
The tests pass with the patch; without the patch
test_style_attribute_quirks.html fails 2 tests.
Attachment #802989 -
Flags: review?(cam)
Comment 2•11 years ago
|
||
Comment on attachment 802989 [details] [diff] [review]
Remove quirk allowing {} around style attribute.
Review of attachment 802989 [details] [diff] [review]:
-----------------------------------------------------------------
(I guess it would have been simpler to write the test as a reftest, but either way.)
Attachment #802989 -
Flags: review?(cam) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Flags: in-testsuite+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #2)
> (I guess it would have been simpler to write the test as a reftest, but
> either way.)
Script tests should be lower-overhead to run, though.
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Comment 6•11 years ago
|
||
Adding dev-doc-needed, I'm not sure this was previously documented, but if so we have to fix the documentation.
Keywords: dev-doc-needed
Comment 7•11 years ago
|
||
"In quirks mode, the CSS parser allows {} around the contents of style attributes (bug 99554)."
https://developer.mozilla.org/en-US/docs/Mozilla_Quirks_Mode_Behavior
Comment 8•11 years ago
|
||
I added a sentence "This behavior is being removed in Firefox 27, for interoperability.", plus a link to this bug, after the quote in Comment 7. Feel free to edit/extend as appropriate.
Leaving dev-doc-needed in case there's anything else that needs updating.
Comment 10•11 years ago
|
||
I've submitted http://hg.csswg.org/test/rev/0274e82f1553 (feel free to review so it can be moved to approved)
Flags: needinfo?(zcorpan)
Comment 11•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•