915075 - tag-release.py still needs to work on Python 2.5 for ESR17

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Calling tag-release.py: /tools/python/bin/python tag-release.py -c mozilla/release-firefox-mozilla-esr17.py -b http://hg.mozilla.org/build/buildbot-configs -t FIREFOX_17_0_9esr_RELEASE
+ /tools/python/bin/python /builds/slave/rel-m-esr17-firefox_tag/scripts/scripts/release/tag-release.py -c mozilla/release-firefox-mozilla-esr17.py -b http://hg.mozilla.org/build/buildbot-configs -t FIREFOX_17_0_9esr_RELEASE
/builds/slave/rel-m-esr17-firefox_tag/scripts/scripts/release/../../lib/python/build/l10n.py:68: Warning: 'with' will become a reserved keyword in Python 2.6
Traceback (most recent call last):
  File "/builds/slave/rel-m-esr17-firefox_tag/scripts/scripts/release/tag-release.py", line 20, in <module>
    from release.l10n import getL10nRepositories
  File "/builds/slave/rel-m-esr17-firefox_tag/scripts/scripts/release/../../lib/python/release/l10n.py", line 8, in <module>
    from build.l10n import getLocalesForChunk
  File "/builds/slave/rel-m-esr17-firefox_tag/scripts/scripts/release/../../lib/python/build/l10n.py", line 68
    with open(path.join(sourceRepoName, ".mozconfig"), "a") as mozconfig:
            ^
SyntaxError: invalid syntax

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] import from the future, THE FUTURE!

r+ from rail on IRC.

https://hg.mozilla.org/build/tools/rev/affb32b6958b retag of FIREFOX_17_0_9esr_{RELEASE,BUILD1}.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Ahem, patching the right file, backing out error:
  https://hg.mozilla.org/build/tools/rev/29d5c694f567

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Third times a charm (right?)
  http://hg.mozilla.org/build/tools/rev/a446cc808185

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Tagging completed.