915079 - composition text should be underlined on Firefox OS devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Yuan Xulei [:yxl] (Leave from May 18)]

When Luke tests the setComposition method of the InputContext API, he found no underline style was applied to the composition text.

The screenshort: https://bugzilla.mozilla.org/attachment.cgi?id=802794

Comment 1

[Yuan Xulei [:yxl] (Leave from May 18)]

`nsLookAndFeel::GetIntImpl` doesn't set the style of composition text in the file mozilla-central/widget/gonk/nsLookAndFeel.cpp.  That seems to be the cause.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Yuan Xulei [:yxl] from comment #1)
> `nsLookAndFeel::GetIntImpl` doesn't set the style of composition text in the
> file mozilla-central/widget/gonk/nsLookAndFeel.cpp.  That seems to be the
> cause.

Yes, it must be so.

Comment 3

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: WIP.patch

I made some changes to widget/gonk/nsLookAndFeel.cpp. I can change the composition text color, but still cannot add the underline style...

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 803734 [details] [diff] [review]
WIP.patch

Well, looks like there is no nsXPLookAndFeel::GetFloatImpl() on Gonk. You need to return 1.0f for eFloatID_IMEUnderlineRelativeSize. If the value is 2.0f, the underline width becomes twice as normal underline. Perhaps, eFloatID_SpellCheckerUnderlineRelativeSize should be implemented too.

BTW,

> +        case eIntID_IMERawInputUnderlineStyle:
> +        case eIntID_IMEConvertedTextUnderlineStyle:
> +            aResult = NS_STYLE_TEXT_DECORATION_STYLE_SOLID;

I like non-solid style better for it, though. But I'm not sure which style is major on other mobile platforms.

Anyway, I'll file a bug for adding API which allows IME to customize each clause style.

Comment 5

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: underline style v1

With nsXPLookAndFeel::GetFloatImpl() implemented, it works.

Comment 6

[Yuan Xulei [:yxl] (Leave from May 18)]

Masayuki, thank you.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f46781f97a1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f46781f97a1