[Session Restore] Don't invalidate the whole tab state when setting/deleting tab values

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Session Restore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 803024 [details] [diff] [review]
update cached tab state when setting/deleting tab values
Attachment #803024 - Flags: review?(dteller)
Comment on attachment 803024 [details] [diff] [review]
update cached tab state when setting/deleting tab values

Review of attachment 803024 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
In addition, this should contribute to increasing our hit rate, so what's not to like?

::: browser/components/sessionstore/src/SessionStore.jsm
@@ +1700,3 @@
>        delete deleteFrom[aKey];
> +
> +      if (Object.keys(deleteFrom).length) {

Nit: Perhaps a small comment here to mention that we're cleaning up to make the objects smaller?
Attachment #803024 - Flags: review?(dteller) → review+
(Assignee)

Comment 2

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=58c13d9f2d8e
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/03ef2b08f65a
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/03ef2b08f65a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.