Closed
Bug 915173
Opened 11 years ago
Closed 11 years ago
[Session Restore] Don't invalidate the whole tab state when setting/deleting tab values
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 26
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
6.10 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #803024 -
Flags: review?(dteller)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 803024 [details] [diff] [review]
update cached tab state when setting/deleting tab values
Review of attachment 803024 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
In addition, this should contribute to increasing our hit rate, so what's not to like?
::: browser/components/sessionstore/src/SessionStore.jsm
@@ +1700,3 @@
> delete deleteFrom[aKey];
> +
> + if (Object.keys(deleteFrom).length) {
Nit: Perhaps a small comment here to mention that we're cleaning up to make the objects smaller?
Attachment #803024 -
Flags: review?(dteller) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
You need to log in
before you can comment on or make changes to this bug.
Description
•