915226 - Start / Stop / Debug shown in project view even when uninstalled

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The Start, Stop, and Debug buttons don't function if an app is not yet installed, but currently they appear for all projects.

It seems like they should be hidden at first, and then enabled once we know the app is on the device.

Comment 1

[Alexandre Poirot [:ochameau]]

I'd really like to see us implement same buttons that already exists in the simulator:

  update: same thing than what refresh already does, but also install an updated version to the simulation
  connect: install if not installed, launch if not running, open a toolbox

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Merge all refresh/start/stop/debug buttons to two buttons called update and connect r=paul

Here is the patch I talked about in each meeting ;)
We end up with same buttons than we were having in the simulator addon.

Comment 3

[Alexandre Poirot [:ochameau]]

I added tooltips for these two buttons.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 803845 [details] [diff] [review]
Merge all refresh/start/stop/debug buttons to two buttons called update and connect r=paul

Review of attachment 803845 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/app-manager.dtd
@@ +45,5 @@
>  <!ENTITY projects.removeApp "Remove">
> +<!ENTITY projects.updateApp "Update">
> +<!ENTITY projects.updateAppTooltip "Execute validation checks and update the app to the connected device">
> +<!ENTITY projects.connectApp "Connect">
> +<!ENTITY projects.connectAppTooltip "Open developer tools connected to this app">

Use Developer Tools (title case) to match what we say in most other places.

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 803845 [details] [diff] [review]
Merge all refresh/start/stop/debug buttons to two buttons called update and connect r=paul

r=me, but:

"Connect" is fuzzy. We already use "connect" for a couple of things:

- device connected via USB (plugged)
- device connected via adb (recognized via adb)
- device connected via the remote protocol

In the UI, it get confusing (especially with the adb integration and the first run screen).

Let's not add another "Connect" button.

How do you like "debug" or "tools" ?

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Renamed button to 'Debug'

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 804737 [details] [diff] [review]
Renamed button to 'Debug'

(In reply to Paul Rouget [:paul] from comment #5)
> How do you like "debug" or "tools" ?

I went for debug, as I like having verb/action for button labels.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Renamed button to 'Debug'

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Renamed button to 'Debug' (finally the right patch!)

Comment 10

[Paul Rouget [:paul]]

I think you didn't upload the right patch (I see "connect").

Comment 11

[Paul Rouget [:paul]]

Attachment: 915226 - ready to land - with "debug" not "connect"

Comment 12

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/fac8738604f5

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fac8738604f5