Closed Bug 915226 Opened 6 years ago Closed 6 years ago
Start / Stop / Debug shown in project view even when uninstalled
The Start, Stop, and Debug buttons don't function if an app is not yet installed, but currently they appear for all projects. It seems like they should be hidden at first, and then enabled once we know the app is on the device.
I'd really like to see us implement same buttons that already exists in the simulator: update: same thing than what refresh already does, but also install an updated version to the simulation connect: install if not installed, launch if not running, open a toolbox
Here is the patch I talked about in each meeting ;) We end up with same buttons than we were having in the simulator addon.
Attachment #803845 - Flags: review?(paul)
I added tooltips for these two buttons.
Comment on attachment 803845 [details] [diff] [review] Merge all refresh/start/stop/debug buttons to two buttons called update and connect r=paul Review of attachment 803845 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/devtools/app-manager.dtd @@ +45,5 @@ > <!ENTITY projects.removeApp "Remove"> > +<!ENTITY projects.updateApp "Update"> > +<!ENTITY projects.updateAppTooltip "Execute validation checks and update the app to the connected device"> > +<!ENTITY projects.connectApp "Connect"> > +<!ENTITY projects.connectAppTooltip "Open developer tools connected to this app"> Use Developer Tools (title case) to match what we say in most other places.
Comment on attachment 803845 [details] [diff] [review] Merge all refresh/start/stop/debug buttons to two buttons called update and connect r=paul r=me, but: "Connect" is fuzzy. We already use "connect" for a couple of things: - device connected via USB (plugged) - device connected via adb (recognized via adb) - device connected via the remote protocol In the UI, it get confusing (especially with the adb integration and the first run screen). Let's not add another "Connect" button. How do you like "debug" or "tools" ?
Attachment #803845 - Flags: review?(paul) → review+
Comment on attachment 804737 [details] [diff] [review] Renamed button to 'Debug' (In reply to Paul Rouget [:paul] from comment #5) > How do you like "debug" or "tools" ? I went for debug, as I like having verb/action for button labels.
Attachment #804737 - Flags: review+
I think you didn't upload the right patch (I see "connect").
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.