Closed Bug 915261 Opened 7 years ago Closed 7 years ago

Build and host adb addon on the internet

Categories

(DevTools Graveyard :: WebIDE, defect, P1)

defect

Tracking

(firefox26 fixed)

RESOLVED FIXED
Tracking Status
firefox26 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

We need to:
 - find the right name for this new addon
 - review its code (from https://github.com/ochameau/adbhelper)
 - build the addon, one xpi per platform
 - host it on AMO or elsewhere
Blocks: appmgr_v1
The App Manager will open this link:
- https://developer.mozilla.org/docs/Mozilla/Firefox_OS/Using_the_App_Manager#Adb_Helper_Add-on

We will only need to add the final link to the addon there (on MDN).
Blocks: 915736
As far as name I think leaving adb out of it might be good. Maybe "Device connection helper" or something.

This is something we can change later and hopefully would go away eventually too so maybe doesn't need too much bikeshedding.
In the first run page, we call it "ADB Helper Add-on"
Uploaded to AMO:
  https://addons.mozilla.org/en-US/firefox/addon/device-connection-helper/

Mdn page updated:
  https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Using_the_App_Manager#ADB_Helper_Add-on

Waiting for AMO review and also registering it to the official mozilla AMO account.

I think we should rename all references about adb.
Depends on: 917707
No longer blocks: 915736
On AMO, it's called "device connection helper". I think it's important to call this addon "ADB Helper". Copy/paste of what I said in bug 917707:

> I strongly disagree with that. Hiding the name of the tool because we think
> it's better for the user will only bring confusion:
> 
> 1) many app developers have heard about ADB
> 2) if there's an issue, then they know that it might be related to ADB, and
> then search on google ("adb problem on linux")
> 3) "Device connection helper" is not less confusing that "ADB Helper". Why
> would you need a "connection" helper in the first place?
> 4) being clear that an extra step is needed to connect the device, and this
> step is named adb, will help when people will ask questions "the adb step
> doesn't seem to work". "connecting" is waaaay to vague (plugging to the USB
> port, connecting with ADB, connecting with Firefox, connecting the toolbox).
> Naming things is good.
(In reply to Paul Rouget [:paul] from comment #5)
> On AMO, it's called "device connection helper". I think it's important to
> call this addon "ADB Helper". Copy/paste of what I said in bug 917707:
> 
> > I strongly disagree with that. Hiding the name of the tool because we think
> > it's better for the user will only bring confusion:
> > 
> > 1) many app developers have heard about ADB
> > 2) if there's an issue, then they know that it might be related to ADB, and
> > then search on google ("adb problem on linux")
> > 3) "Device connection helper" is not less confusing that "ADB Helper". Why
> > would you need a "connection" helper in the first place?
> > 4) being clear that an extra step is needed to connect the device, and this
> > step is named adb, will help when people will ask questions "the adb step
> > doesn't seem to work". "connecting" is waaaay to vague (plugging to the USB
> > port, connecting with ADB, connecting with Firefox, connecting the toolbox).
> > Naming things is good.

Seems a valid point. My question is going forwards will new Firefox OS app developers know what ADB is or will it just be a confusing abbreviation to them that when they google find is android related?
(Dave, let's have this discussion in bug 917707)
(In reply to Alexandre Poirot (:ochameau) from comment #4)
> Uploaded to AMO:
>   https://addons.mozilla.org/en-US/firefox/addon/device-connection-helper/
> 
> Mdn page updated:
>  
> https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/
> Using_the_App_Manager#ADB_Helper_Add-on
> 
> Waiting for AMO review and also registering it to the official mozilla AMO
> account.

Can we add a link to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Using_the_App_Manager in the description? Once it's under the Mozilla official account, can we still easily change things (like the description)?

> I think we should rename all references about adb.

I think we should do the exact opposite :) (bug 917707)
Priority: -- → P1
Assignee: nobody → poirot.alex
Renamed to ADB Helper and pushed a new version to fix the startup hang:
https://addons.mozilla.org/en-US/firefox/addon/adb-helper/
Kris, Could you register this addon to the mozilla account? I'd like to unregister it from my personal account in order to make it more official.
Also, if we can get it reviewed, that would be great. This addon is basically a piece of the Firefox OS Simulator addon, just the part related to ADB.
Its sourcecode is hosted on this repo: https://github.com/ochameau/adbhelper
Flags: needinfo?(kmaglione+bmo)
I added Mozilla as an author. In the future, you can do this yourself for any add-on. Just add 'addons-team@mozilla.com' as an owner.
Flags: needinfo?(kmaglione+bmo)
https://addons.mozilla.org/en-US/firefox/addon/adb-helper/ is 404 now.
Flags: needinfo?(kmaglione+bmo)
I would imagine it is because having got a r- from Kris during the addon review.
Flags: needinfo?(kmaglione+bmo)
Depends on: 920586
Adb helper addon is now hosted on ftp, right here:
https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/adb-helper/
And is going to be updated from it.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.